Merge pull request #19164 from vespa-engine/vekterli/aggregate-pending-operation-stats-across-stripes

Aggregate pending operation stats across all stripes in stripe guard

1 files changed, 20 insertions, 0 deletions

diff --git a/storage/src/tests/distributor/multi_thread_stripe_access_guard_test.cpp b/storage/src/tests/distributor/multi_thread_stripe_access_guard_test.cpp
index ba28396886f..07005aa898b 100644
--- a/storage/src/tests/distributor/multi_thread_stripe_access_guard_test.cpp
+++ b/storage/src/tests/distributor/multi_thread_stripe_access_guard_test.cpp
@@ -18,6 +18,7 @@ namespace storage::distributor {
 struct AggregationTestingMockTickableStripe : MockTickableStripe {
     PotentialDataLossReport report;
     std::vector<dbtransition::Entry> entries;
+    StripeAccessGuard::PendingOperationStats pending_stats{0, 0};
 
     PotentialDataLossReport remove_superfluous_buckets(document::BucketSpace, const lib::ClusterState&, bool) override {
         return report;
@@ -38,6 +39,10 @@ struct AggregationTestingMockTickableStripe : MockTickableStripe {
         return result;
     }
 
+    StripeAccessGuard::PendingOperationStats pending_operation_stats() const override {
+        return pending_stats;
+    }
+
     bool tick() override {
         return false;
     }
@@ -96,6 +101,21 @@ TEST_F(MultiThreadedStripeAccessGuardTest, remove_superfluous_buckets_aggregates
     EXPECT_EQ(report.documents, 680);
 }
 
+TEST_F(MultiThreadedStripeAccessGuardTest, pending_operation_stats_aggregates_stats_across_stripes) {
+    using Stats = StripeAccessGuard::PendingOperationStats;
+    _stripe0.pending_stats = Stats(20, 100);
+    _stripe1.pending_stats = Stats(5,  200);
+    _stripe2.pending_stats = Stats(7,  350);
+    _stripe3.pending_stats = Stats(3,  30);
+    start_pool_with_stripes();
+
+    auto guard = _accessor.rendezvous_and_hold_all();
+    auto pending_stats = guard->pending_operation_stats();
+
+    EXPECT_EQ(pending_stats.external_load_operations, 35);
+    EXPECT_EQ(pending_stats.maintenance_operations, 680);
+}
+
 TEST_F(MultiThreadedStripeAccessGuardTest, merge_entries_into_db_operates_across_all_stripes) {
     start_pool_with_stripes();
     // Note: The bucket key is calculated by reversing the bits of the raw bucket id.