aboutsummaryrefslogtreecommitdiffstats
path: root/storage/src
diff options
context:
space:
mode:
authorTor Brede Vekterli <vekterli@oath.com>2018-04-26 11:26:08 +0000
committerTor Brede Vekterli <vekterli@oath.com>2018-04-26 11:26:08 +0000
commitea6d1629de22085eed565e4a47ccf79c61cb318e (patch)
treec6e10c493c9950888cb563e04139a38449b05b72 /storage/src
parentc7381ee3bd04c3fc71ef0f02c1c1341c0d1608e6 (diff)
Don't be silly and deref an iterator after it has been erased
Diffstat (limited to 'storage/src')
-rw-r--r--storage/src/vespa/storage/storageserver/statemanager.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/storage/src/vespa/storage/storageserver/statemanager.cpp b/storage/src/vespa/storage/storageserver/statemanager.cpp
index 693e56133df..d6ca8c266d3 100644
--- a/storage/src/vespa/storage/storageserver/statemanager.cpp
+++ b/storage/src/vespa/storage/storageserver/statemanager.cpp
@@ -553,8 +553,8 @@ StateManager::sendGetNodeStateReplies(framework::MilliSecTime olderThanTime,
replies.emplace_back(std::make_shared<api::GetNodeStateReply>(*it->second, *_nodeState));
auto eraseIt = it++;
- _queuedStateRequests.erase(eraseIt);
mark_controller_as_having_observed_explicit_node_state(eraseIt->second->getSourceIndex());
+ _queuedStateRequests.erase(eraseIt);
} else {
++it;
}