diff options
| author | Henning Baldersheim <balder@yahoo-inc.com> | 2020-11-23 11:35:11 +0000 |
|---|---|---|
| committer | Henning Baldersheim <balder@yahoo-inc.com> | 2020-11-23 11:35:11 +0000 |
| commit | ca29131b659c51935fe6a6cdf3ae93207c79e714 (patch) | |
| tree | e0275ff0b8347ed30cf599f950eadfc984296ee4 /storage/src | |
| parent | da48ee20f9d5981e4aaa5cb719f0b3fea57d17e6 (diff) | |
Move instead of copy.
Diffstat (limited to 'storage/src')
| -rw-r--r-- | storage/src/vespa/storage/storageserver/communicationmanager.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/storage/src/vespa/storage/storageserver/communicationmanager.cpp b/storage/src/vespa/storage/storageserver/communicationmanager.cpp index f0c62f128cf..6ad5410765f 100644 --- a/storage/src/vespa/storage/storageserver/communicationmanager.cpp +++ b/storage/src/vespa/storage/storageserver/communicationmanager.cpp @@ -102,7 +102,7 @@ CommunicationManager::handleMessage(std::unique_ptr<mbus::Message> msg) return; } - cmd->setTrace(vespalib::Trace(docMsgPtr->getTrace())); // Can it be moved ? + cmd->setTrace(std::move(docMsgPtr->getTrace())); cmd->setTransportContext(std::make_unique<StorageTransportContext>(std::move(docMsgPtr))); enqueue_or_process(std::move(cmd)); @@ -114,7 +114,7 @@ CommunicationManager::handleMessage(std::unique_ptr<mbus::Message> msg) //TODO: Can it be moved ? std::shared_ptr<api::StorageCommand> cmd = storMsgPtr->getCommand(); cmd->setTimeout(storMsgPtr->getTimeRemaining()); - cmd->setTrace(vespalib::Trace(storMsgPtr->getTrace())); // Can it be moved ? + cmd->setTrace(std::move(storMsgPtr->getTrace())); cmd->setTransportContext(std::make_unique<StorageTransportContext>(std::move(storMsgPtr))); enqueue_or_process(std::move(cmd)); @@ -203,12 +203,12 @@ CommunicationManager::handleReply(std::unique_ptr<mbus::Reply> reply) _docApiConverter.toStorageAPI(static_cast<documentapi::DocumentReply&>(*reply), *originalCommand)); if (sar) { - sar->setTrace(vespalib::Trace(reply->getTrace())); // Can it be moved ? + sar->setTrace(std::move(reply->getTrace())); receiveStorageReply(sar); } } else if (protocolName == mbusprot::StorageProtocol::NAME) { mbusprot::StorageReply* sr(static_cast<mbusprot::StorageReply*>(reply.get())); - sr->getReply()->setTrace(vespalib::Trace(reply->getTrace())); + sr->getReply()->setTrace(std::move(reply->getTrace())); receiveStorageReply(sr->getReply()); } else { LOGBM(warning, "Received unsupported reply type %d for protocol '%s'.", |