summaryrefslogtreecommitdiffstats
path: root/storage
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2021-10-18 14:07:40 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2021-10-18 14:07:40 +0000
commit901b0e20ed17cd86d1227c9652f0f250b25bea86 (patch)
treecc7313e0e4389d22fbeeaf7d1e75575fc3c07024 /storage
parentb2ad54a6e83481106835bd27cfdd0d7b60d839a0 (diff)
Add TODO for error counting/logging.
Diffstat (limited to 'storage')
-rw-r--r--storage/src/vespa/storage/persistence/asynchandler.cpp4
1 files changed, 3 insertions, 1 deletions
diff --git a/storage/src/vespa/storage/persistence/asynchandler.cpp b/storage/src/vespa/storage/persistence/asynchandler.cpp
index f2ed1922b60..d150f5600e5 100644
--- a/storage/src/vespa/storage/persistence/asynchandler.cpp
+++ b/storage/src/vespa/storage/persistence/asynchandler.cpp
@@ -167,7 +167,9 @@ AsyncHandler::handleDeleteBucket(api::DeleteBucketCommand& cmd, MessageTracker::
return tracker;
}
- auto task = makeResultTask([this, tracker = std::move(tracker), bucket=cmd.getBucket()](spi::Result::UP ) {
+ auto task = makeResultTask([this, tracker = std::move(tracker), bucket=cmd.getBucket()](spi::Result::UP ignored) {
+ // TODO Even if an non OK response can not be handled sanely we might probably log a message, or increment a metric
+ (void) ignored;
StorBucketDatabase &db(_env.getBucketDatabase(bucket.getBucketSpace()));
StorBucketDatabase::WrappedEntry entry = db.get(bucket.getBucketId(), "onDeleteBucket");
if (entry.exist() && entry->getMetaCount() > 0) {