summaryrefslogtreecommitdiffstats
path: root/storage
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2020-04-30 13:31:15 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2020-04-30 13:31:15 +0000
commit704b6635543a6e0b1489f6371de865383575c6e3 (patch)
tree133c64d579995c9e0f083e96e23e4f6351c78f71 /storage
parente3da8487f35e6ff4ea65f27ba6f3e1bcb89d32a2 (diff)
Add class comments and resolve PR comments.
Diffstat (limited to 'storage')
-rw-r--r--storage/src/vespa/storage/persistence/persistenceutil.cpp10
1 files changed, 4 insertions, 6 deletions
diff --git a/storage/src/vespa/storage/persistence/persistenceutil.cpp b/storage/src/vespa/storage/persistence/persistenceutil.cpp
index c46b9ab7059..9095b351f64 100644
--- a/storage/src/vespa/storage/persistence/persistenceutil.cpp
+++ b/storage/src/vespa/storage/persistence/persistenceutil.cpp
@@ -52,12 +52,7 @@ MessageTracker::setMetric(FileStorThreadMetrics::Op& metric) {
_metric = &metric;
}
-MessageTracker::~MessageTracker()
-{
- if (_reply.get() && _reply->getResult().success()) {
- _metric->latency.addValue(_timer.getElapsedTimeAsDouble());
- }
-}
+MessageTracker::~MessageTracker() = default;
void
MessageTracker::sendReply() {
@@ -70,6 +65,9 @@ MessageTracker::sendReply() {
_env.setBucketInfo(*this, _bucketLock->getBucket());
}
}
+ if (getReply().getResult().success()) {
+ _metric->latency.addValue(_timer.getElapsedTimeAsDouble());
+ }
LOG(spam, "Sending reply up: %s %" PRIu64,
getReply().toString().c_str(), getReply().getMsgId());
_env._fileStorHandler.sendReply(std::move(_reply));