summaryrefslogtreecommitdiffstats
path: root/storage
diff options
context:
space:
mode:
authorTor Brede Vekterli <vekterli@yahooinc.com>2022-05-03 12:40:12 +0000
committerTor Brede Vekterli <vekterli@yahooinc.com>2022-05-03 12:40:12 +0000
commitb63e61bf568964e50a455d1721064fe068bb3cd2 (patch)
tree30ff84ef112d91d3af5d6d51d2c46f050ac86d7e /storage
parentba40d4f84d8b5a62634d68ac9ce671a5044210b2 (diff)
Add lock around visitor queue size read during metric snapshot callback
Mutex should have very little contention in the common case.
Diffstat (limited to 'storage')
-rw-r--r--storage/src/vespa/storage/visiting/visitormanager.cpp1
1 files changed, 1 insertions, 0 deletions
diff --git a/storage/src/vespa/storage/visiting/visitormanager.cpp b/storage/src/vespa/storage/visiting/visitormanager.cpp
index 282299ebbc1..5decf700633 100644
--- a/storage/src/vespa/storage/visiting/visitormanager.cpp
+++ b/storage/src/vespa/storage/visiting/visitormanager.cpp
@@ -86,6 +86,7 @@ VisitorManager::create_and_start_manager_thread()
void
VisitorManager::updateMetrics(const MetricLockGuard &)
{
+ std::lock_guard sync(_visitorLock);
_metrics->queueSize.addValue(_visitorQueue.size());
}