diff options
| author | Tor Brede Vekterli <vekterli@yahoo-inc.com> | 2016-12-21 15:55:10 +0100 |
|---|---|---|
| committer | Tor Brede Vekterli <vekterli@yahoo-inc.com> | 2016-12-21 15:55:10 +0100 |
| commit | 75476ef226918e21e890fd665211380460c3f921 (patch) | |
| tree | 2c94107a4514cf2341d7f554b238970b34672d96 /storage | |
| parent | 94c9c9ba2167c4cdaf934f977399c71280e5b8b6 (diff) | |
Use correct metric value increment method
Turns out, inc() and addValue() have completely different semantics for
how values are actually aggregated. inc() maintains a running value
while addValue() treats each invocation as a separate sample (which is
what we want).
Diffstat (limited to 'storage')
| -rw-r--r-- | storage/src/vespa/storage/distributor/operations/external/visitoroperation.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/storage/src/vespa/storage/distributor/operations/external/visitoroperation.cpp b/storage/src/vespa/storage/distributor/operations/external/visitoroperation.cpp index fdd309fabd3..ec165b0ee25 100644 --- a/storage/src/vespa/storage/distributor/operations/external/visitoroperation.cpp +++ b/storage/src/vespa/storage/distributor/operations/external/visitoroperation.cpp @@ -1001,9 +1001,9 @@ VisitorOperation::updateReplyMetrics(const api::ReturnCode& result) return; } _metrics.latency.addValue(_operationTimer.getElapsedTimeAsDouble()); - _metrics.buckets_per_visitor.inc(_visitorStatistics.getBucketsVisited()); - _metrics.docs_per_visitor.inc(_visitorStatistics.getDocumentsVisited()); - _metrics.bytes_per_visitor.inc(_visitorStatistics.getBytesVisited()); + _metrics.buckets_per_visitor.addValue(_visitorStatistics.getBucketsVisited()); + _metrics.docs_per_visitor.addValue(_visitorStatistics.getDocumentsVisited()); + _metrics.bytes_per_visitor.addValue(_visitorStatistics.getBytesVisited()); } void |