summaryrefslogtreecommitdiffstats
path: root/storage
diff options
context:
space:
mode:
authorTor Egge <Tor.Egge@broadpark.no>2020-12-05 16:23:51 +0100
committerTor Egge <Tor.Egge@broadpark.no>2020-12-05 16:23:51 +0100
commit7ce18031173d52b93073fa9fd9d2c57a9fdd1390 (patch)
treea66806e7817d9b963e376b43765f7b8e36294f4d /storage
parent4b5cb9770f115b73f03fe59d6d1a4f30097cf739 (diff)
Add noexcept specifiers to non-throwing constructors and operators.
Diffstat (limited to 'storage')
-rw-r--r--storage/src/vespa/storage/distributor/bucket_space_distribution_context.cpp2
-rw-r--r--storage/src/vespa/storage/distributor/bucket_space_distribution_context.h2
-rw-r--r--storage/src/vespa/storage/distributor/pendingmessagetracker.cpp2
-rw-r--r--storage/src/vespa/storage/distributor/pendingmessagetracker.h2
-rw-r--r--storage/src/vespa/storage/persistence/filestorage/filestorhandlerimpl.cpp2
-rw-r--r--storage/src/vespa/storage/persistence/filestorage/filestorhandlerimpl.h2
-rw-r--r--storage/src/vespa/storage/visiting/visitorthread.cpp4
-rw-r--r--storage/src/vespa/storage/visiting/visitorthread.h6
8 files changed, 11 insertions, 11 deletions
diff --git a/storage/src/vespa/storage/distributor/bucket_space_distribution_context.cpp b/storage/src/vespa/storage/distributor/bucket_space_distribution_context.cpp
index 53040bc42b1..c6def05ef25 100644
--- a/storage/src/vespa/storage/distributor/bucket_space_distribution_context.cpp
+++ b/storage/src/vespa/storage/distributor/bucket_space_distribution_context.cpp
@@ -10,7 +10,7 @@ BucketSpaceDistributionContext::BucketSpaceDistributionContext(
std::shared_ptr<const lib::ClusterState> default_active_cluster_state,
std::shared_ptr<const lib::ClusterState> pending_cluster_state,
std::shared_ptr<const lib::Distribution> distribution,
- uint16_t this_node_index)
+ uint16_t this_node_index) noexcept
: _active_cluster_state(std::move(active_cluster_state)),
_default_active_cluster_state(std::move(default_active_cluster_state)),
_pending_cluster_state(std::move(pending_cluster_state)),
diff --git a/storage/src/vespa/storage/distributor/bucket_space_distribution_context.h b/storage/src/vespa/storage/distributor/bucket_space_distribution_context.h
index 7a9c0fcae60..662a1b1daac 100644
--- a/storage/src/vespa/storage/distributor/bucket_space_distribution_context.h
+++ b/storage/src/vespa/storage/distributor/bucket_space_distribution_context.h
@@ -29,7 +29,7 @@ public:
std::shared_ptr<const lib::ClusterState> default_active_cluster_state,
std::shared_ptr<const lib::ClusterState> pending_cluster_state,
std::shared_ptr<const lib::Distribution> distribution,
- uint16_t this_node_index);
+ uint16_t this_node_index) noexcept;
~BucketSpaceDistributionContext();
static std::shared_ptr<BucketSpaceDistributionContext> make_state_transition(
diff --git a/storage/src/vespa/storage/distributor/pendingmessagetracker.cpp b/storage/src/vespa/storage/distributor/pendingmessagetracker.cpp
index 44ab91528f2..f84eafe8d85 100644
--- a/storage/src/vespa/storage/distributor/pendingmessagetracker.cpp
+++ b/storage/src/vespa/storage/distributor/pendingmessagetracker.cpp
@@ -22,7 +22,7 @@ PendingMessageTracker::PendingMessageTracker(framework::ComponentRegister& cr)
PendingMessageTracker::~PendingMessageTracker() = default;
PendingMessageTracker::MessageEntry::MessageEntry(TimePoint timeStamp_, uint32_t msgType_, uint32_t priority_,
- uint64_t msgId_, document::Bucket bucket_, uint16_t nodeIdx_)
+ uint64_t msgId_, document::Bucket bucket_, uint16_t nodeIdx_) noexcept
: timeStamp(timeStamp_),
msgType(msgType_),
priority(priority_),
diff --git a/storage/src/vespa/storage/distributor/pendingmessagetracker.h b/storage/src/vespa/storage/distributor/pendingmessagetracker.h
index 51c112152b6..51971a276b4 100644
--- a/storage/src/vespa/storage/distributor/pendingmessagetracker.h
+++ b/storage/src/vespa/storage/distributor/pendingmessagetracker.h
@@ -136,7 +136,7 @@ private:
uint16_t nodeIdx;
MessageEntry(TimePoint timeStamp, uint32_t msgType, uint32_t priority,
- uint64_t msgId, document::Bucket bucket, uint16_t nodeIdx);
+ uint64_t msgId, document::Bucket bucket, uint16_t nodeIdx) noexcept;
vespalib::string toHtml() const;
};
diff --git a/storage/src/vespa/storage/persistence/filestorage/filestorhandlerimpl.cpp b/storage/src/vespa/storage/persistence/filestorage/filestorhandlerimpl.cpp
index 5a7a598fb4c..d60b48a54ae 100644
--- a/storage/src/vespa/storage/persistence/filestorage/filestorhandlerimpl.cpp
+++ b/storage/src/vespa/storage/persistence/filestorage/filestorhandlerimpl.cpp
@@ -852,7 +852,7 @@ FileStorHandlerImpl::MessageEntry::MessageEntry(const std::shared_ptr<api::Stora
{ }
-FileStorHandlerImpl::MessageEntry::MessageEntry(const MessageEntry& entry)
+FileStorHandlerImpl::MessageEntry::MessageEntry(const MessageEntry& entry) noexcept
: _command(entry._command),
_timer(entry._timer),
_bucket(entry._bucket),
diff --git a/storage/src/vespa/storage/persistence/filestorage/filestorhandlerimpl.h b/storage/src/vespa/storage/persistence/filestorage/filestorhandlerimpl.h
index b081d5f75e9..6006fdeb7fd 100644
--- a/storage/src/vespa/storage/persistence/filestorage/filestorhandlerimpl.h
+++ b/storage/src/vespa/storage/persistence/filestorage/filestorhandlerimpl.h
@@ -54,7 +54,7 @@ public:
MessageEntry(const std::shared_ptr<api::StorageMessage>& cmd, const document::Bucket &bId);
MessageEntry(MessageEntry &&) noexcept ;
- MessageEntry(const MessageEntry &);
+ MessageEntry(const MessageEntry &) noexcept;
MessageEntry & operator = (const MessageEntry &) = delete;
~MessageEntry();
diff --git a/storage/src/vespa/storage/visiting/visitorthread.cpp b/storage/src/vespa/storage/visiting/visitorthread.cpp
index 1c89acf74b0..918a0ce2ee3 100644
--- a/storage/src/vespa/storage/visiting/visitorthread.cpp
+++ b/storage/src/vespa/storage/visiting/visitorthread.cpp
@@ -22,7 +22,7 @@ using storage::api::ReturnCode;
namespace storage {
-VisitorThread::Event::Event(Event&& other)
+VisitorThread::Event::Event(Event&& other) noexcept
: _visitorId(other._visitorId),
_message(other._message),
_mbusReply(std::move(other._mbusReply)),
@@ -34,7 +34,7 @@ VisitorThread::Event::Event(Event&& other)
VisitorThread::Event::~Event() = default;
VisitorThread::Event&
-VisitorThread::Event::operator= (Event&& other)
+VisitorThread::Event::operator= (Event&& other) noexcept
{
_visitorId = other._visitorId;
_message = other._message;
diff --git a/storage/src/vespa/storage/visiting/visitorthread.h b/storage/src/vespa/storage/visiting/visitorthread.h
index 3dfe9571c1f..6df4ddd8819 100644
--- a/storage/src/vespa/storage/visiting/visitorthread.h
+++ b/storage/src/vespa/storage/visiting/visitorthread.h
@@ -54,9 +54,9 @@ class VisitorThread : public framework::Runnable,
metrics::MetricTimer _timer;
Type _type;
- Event() : _visitorId(0), _message(), _timer(), _type(NONE) {}
- Event(Event&& other);
- Event& operator= (Event&& other);
+ Event() noexcept : _visitorId(0), _message(), _timer(), _type(NONE) {}
+ Event(Event&& other) noexcept;
+ Event& operator= (Event&& other) noexcept;
Event(const Event& other) = delete;
Event& operator= (const Event& other) = delete;
Event(api::VisitorId visitor, mbus::Reply::UP reply);