summaryrefslogtreecommitdiffstats
path: root/storage
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2020-01-20 15:50:01 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2020-01-20 15:50:01 +0000
commit1f9cb926b91659840e687f9cab0f508522d58690 (patch)
treebff0152fd295b4d88f6a65089c09db82b6e00810 /storage
parent1d3fe1bedb648cfd497eeee61478fa45f332255b (diff)
Make it known that getting serialized size will always be expensive.
Diffstat (limited to 'storage')
-rw-r--r--storage/src/tests/visiting/visitormanagertest.cpp3
-rw-r--r--storage/src/vespa/storage/visiting/recoveryvisitor.cpp4
2 files changed, 4 insertions, 3 deletions
diff --git a/storage/src/tests/visiting/visitormanagertest.cpp b/storage/src/tests/visiting/visitormanagertest.cpp
index 2544fcc9a4b..62dbce890cc 100644
--- a/storage/src/tests/visiting/visitormanagertest.cpp
+++ b/storage/src/tests/visiting/visitormanagertest.cpp
@@ -20,6 +20,7 @@
#include <vespa/documentapi/messagebus/messages/visitor.h>
#include <vespa/config/common/exceptions.h>
#include <vespa/vespalib/gtest/gtest.h>
+#include <vespa/vespalib/objects/nbostream.h>
#include <gmock/gmock.h>
#include <optional>
#include <thread>
@@ -337,7 +338,7 @@ int getTotalSerializedSize(const std::vector<document::Document::SP>& docs)
{
int total = 0;
for (size_t i = 0; i < docs.size(); ++i) {
- total += int(docs[i]->getSerializedSize());
+ total += int(docs[i]->serialize().size());
}
return total;
}
diff --git a/storage/src/vespa/storage/visiting/recoveryvisitor.cpp b/storage/src/vespa/storage/visiting/recoveryvisitor.cpp
index 8bac2bac10a..80e74e890a1 100644
--- a/storage/src/vespa/storage/visiting/recoveryvisitor.cpp
+++ b/storage/src/vespa/storage/visiting/recoveryvisitor.cpp
@@ -2,7 +2,7 @@
#include "recoveryvisitor.h"
-
+#include <vespa/vespalib/objects/nbostream.h>
#include <vespa/documentapi/messagebus/messages/visitor.h>
#include <vespa/vespalib/text/stringtokenizer.h>
#include <vespa/vespalib/stllike/hash_map.hpp>
@@ -70,7 +70,7 @@ RecoveryVisitor::handleDocuments(const document::BucketId& bid,
}
}
- hitCounter.addHit(doc->getId(), doc->getSerializedSize());
+ hitCounter.addHit(doc->getId(), doc->serialize().size());
int64_t timestamp = doc->getLastModified();
cmd->getDocuments().push_back(documentapi::DocumentListMessage::Entry(