summaryrefslogtreecommitdiffstats
path: root/storage
diff options
context:
space:
mode:
authorArnstein Ressem <aressem@gmail.com>2017-10-02 14:51:12 +0200
committerGitHub <noreply@github.com>2017-10-02 14:51:12 +0200
commit4a46361afd24f614291a83a3d0cad02e57754040 (patch)
treef9ef525845c92cc9fe713db2d818a70261b65660 /storage
parent745ebb77abd4c51bcf3b9a38f162f3c6258012f7 (diff)
Revert "Havardpe/avoid reading past json value in slime json parser"
Diffstat (limited to 'storage')
-rw-r--r--storage/src/tests/common/hostreporter/util.cpp6
-rw-r--r--storage/src/tests/storageserver/statereportertest.cpp2
2 files changed, 4 insertions, 4 deletions
diff --git a/storage/src/tests/common/hostreporter/util.cpp b/storage/src/tests/common/hostreporter/util.cpp
index e0563a431e6..a9578e8d8cf 100644
--- a/storage/src/tests/common/hostreporter/util.cpp
+++ b/storage/src/tests/common/hostreporter/util.cpp
@@ -24,10 +24,10 @@ reporterToSlime(HostReporter &hostReporter, vespalib::Slime &slime) {
hostReporter.report(stream);
stream << End();
std::string jsonData = json.str();
- size_t parsed = JsonFormat::decode(Memory(jsonData), slime);
+ size_t parsedSize = JsonFormat::decode(Memory(jsonData), slime);
- if (parsed == 0) {
- CPPUNIT_FAIL("jsonData is not json:\n" + jsonData);
+ if (jsonData.size() != parsedSize) {
+ CPPUNIT_FAIL("Sizes of jsonData mismatched, probably not json:\n" + jsonData);
}
}
}
diff --git a/storage/src/tests/storageserver/statereportertest.cpp b/storage/src/tests/storageserver/statereportertest.cpp
index 3a71444e74c..8622f241a18 100644
--- a/storage/src/tests/storageserver/statereportertest.cpp
+++ b/storage/src/tests/storageserver/statereportertest.cpp
@@ -130,7 +130,7 @@ vespalib::Slime slime; \
size_t parsed = JsonFormat::decode(vespalib::Memory(jsonData), slime); \
vespalib::SimpleBuffer buffer; \
JsonFormat::encode(slime, buffer, false); \
- if (parsed == 0) { \
+ if (jsonData.size() != parsed) { \
std::ostringstream error; \
error << "Failed to parse JSON: '\n" \
<< jsonData << "'\n:" << buffer.get().make_string() << "\n"; \