summaryrefslogtreecommitdiffstats
path: root/storage
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2019-08-15 20:33:36 +0200
committerHenning Baldersheim <balder@yahoo-inc.com>2019-08-15 20:33:36 +0200
commitc5dd20f345de738acd500a91f5c400198f6c3ef6 (patch)
treefb2e57127c6122cdc217698d30a96c995235f335 /storage
parent7626ef4e275cc4f8ad81e5e31a56aad2f7c62593 (diff)
Follow up from review comments.
Diffstat (limited to 'storage')
-rw-r--r--storage/src/vespa/storage/distributor/operations/external/visitoroperation.cpp10
-rw-r--r--storage/src/vespa/storage/distributor/operations/external/visitoroperation.h1
2 files changed, 0 insertions, 11 deletions
diff --git a/storage/src/vespa/storage/distributor/operations/external/visitoroperation.cpp b/storage/src/vespa/storage/distributor/operations/external/visitoroperation.cpp
index f777f5de7c3..3aadce4d18e 100644
--- a/storage/src/vespa/storage/distributor/operations/external/visitoroperation.cpp
+++ b/storage/src/vespa/storage/distributor/operations/external/visitoroperation.cpp
@@ -566,12 +566,6 @@ VisitorOperation::pickTargetNode(
return potentialNodes.front().getNode();
}
-bool
-VisitorOperation::parseDocumentSelection(DistributorMessageSender& )
-{
- return true;
-}
-
void
VisitorOperation::onStart(DistributorMessageSender& sender)
{
@@ -579,10 +573,6 @@ VisitorOperation::onStart(DistributorMessageSender& sender)
return;
}
- if (!parseDocumentSelection(sender)) {
- return;
- }
-
expandBucket();
startNewVisitors(sender);
diff --git a/storage/src/vespa/storage/distributor/operations/external/visitoroperation.h b/storage/src/vespa/storage/distributor/operations/external/visitoroperation.h
index abf00c51f12..ebb5ed4c6aa 100644
--- a/storage/src/vespa/storage/distributor/operations/external/visitoroperation.h
+++ b/storage/src/vespa/storage/distributor/operations/external/visitoroperation.h
@@ -100,7 +100,6 @@ private:
const std::vector<uint16_t>& triedNodes);
void attemptToParseOrderingSelector();
bool documentSelectionMayHaveOrdering() const;
- bool parseDocumentSelection(DistributorMessageSender& sender);
bool maySendNewStorageVisitors() const noexcept;
void startNewVisitors(DistributorMessageSender& sender);
void initializeActiveNodes();