summaryrefslogtreecommitdiffstats
path: root/storage
diff options
context:
space:
mode:
authorTor Brede Vekterli <vekterli@verizonmedia.com>2020-09-14 13:45:00 +0000
committerTor Brede Vekterli <vekterli@verizonmedia.com>2020-09-14 13:45:00 +0000
commit1cd5272ae14b7f61d24552fef60ac6c763879fd5 (patch)
treed2f8a3de08f3e56a30247bc7422a3ff4b4eb5d1f /storage
parent4f1b8b7d2abfc70b72ecc5be2b9a720d22de4947 (diff)
Reduce log levels to debug
Diffstat (limited to 'storage')
-rw-r--r--storage/src/vespa/storage/storageserver/communicationmanager.cpp2
-rw-r--r--storage/src/vespa/storage/storageserver/rpc/caching_rpc_target_resolver.cpp7
-rw-r--r--storage/src/vespa/storage/storageserver/rpc/storage_api_rpc_service.cpp10
3 files changed, 9 insertions, 10 deletions
diff --git a/storage/src/vespa/storage/storageserver/communicationmanager.cpp b/storage/src/vespa/storage/storageserver/communicationmanager.cpp
index 397623dc491..0a4659abdf3 100644
--- a/storage/src/vespa/storage/storageserver/communicationmanager.cpp
+++ b/storage/src/vespa/storage/storageserver/communicationmanager.cpp
@@ -564,7 +564,7 @@ CommunicationManager::sendCommand(
switch (address.getProtocol()) {
case api::StorageMessageAddress::STORAGE:
{
- LOG(info, "Send to %s: %s", address.toString().c_str(), msg->toString().c_str());
+ LOG(debug, "Send to %s: %s", address.toString().c_str(), msg->toString().c_str());
if (_use_direct_storageapi_rpc) {
_storage_api_rpc_service->send_rpc_v1_request(msg);
} else {
diff --git a/storage/src/vespa/storage/storageserver/rpc/caching_rpc_target_resolver.cpp b/storage/src/vespa/storage/storageserver/rpc/caching_rpc_target_resolver.cpp
index 5957cd33954..5241ec6f769 100644
--- a/storage/src/vespa/storage/storageserver/rpc/caching_rpc_target_resolver.cpp
+++ b/storage/src/vespa/storage/storageserver/rpc/caching_rpc_target_resolver.cpp
@@ -55,7 +55,7 @@ CachingRpcTargetResolver::consider_update_target(const vespalib::string& slobrok
&& (itr->second->_target->is_valid())
&& (itr->second->_spec == connection_spec))
{
- LOG(info, "Updating existing mapping '%s' -> '%s' (gen %u) to gen %u",
+ LOG(debug, "Updating existing mapping '%s' -> '%s' (gen %u) to gen %u",
slobrok_id.c_str(), connection_spec.c_str(), itr->second->_slobrok_gen, curr_slobrok_gen);
itr->second->_slobrok_gen = curr_slobrok_gen;
return itr->second;
@@ -72,7 +72,7 @@ CachingRpcTargetResolver::insert_new_target_mapping(const vespalib::string& slob
assert(target);
std::shared_ptr<RpcTarget> rpc_target(std::move(target));
_targets[slobrok_id] = rpc_target;
- LOG(info, "Added mapping '%s' -> '%s' at gen %u", slobrok_id.c_str(), connection_spec.c_str(), curr_slobrok_gen);
+ LOG(debug, "Added mapping '%s' -> '%s' at gen %u", slobrok_id.c_str(), connection_spec.c_str(), curr_slobrok_gen);
return rpc_target;
}
@@ -86,8 +86,7 @@ CachingRpcTargetResolver::resolve_rpc_target(const api::StorageMessageAddress& a
}
auto specs = _slobrok_mirror.lookup(slobrok_id); // FIXME string type mismatch; implicit conv!
if (specs.empty()) {
- // TODO: Replace all info logging with debug logging.
- LOG(info, "Found no mapping for '%s'", slobrok_id.c_str());
+ LOG(debug, "Found no mapping for '%s'", slobrok_id.c_str());
// TODO return potentially stale existing target if no longer existing in SB?
// TODO or clear any existing mapping?
return {};
diff --git a/storage/src/vespa/storage/storageserver/rpc/storage_api_rpc_service.cpp b/storage/src/vespa/storage/storageserver/rpc/storage_api_rpc_service.cpp
index d8535b34656..5e974eb4cce 100644
--- a/storage/src/vespa/storage/storageserver/rpc/storage_api_rpc_service.cpp
+++ b/storage/src/vespa/storage/storageserver/rpc/storage_api_rpc_service.cpp
@@ -141,7 +141,7 @@ void StorageApiRpcService::uncompress_rpc_payload(
}
void StorageApiRpcService::RPC_rpc_v1_send(FRT_RPCRequest* req) {
- LOG(info, "Server: received rpc.v1 request");
+ LOG(debug, "Server: received rpc.v1 request");
// TODO do we need to manually check the parameter/return spec here?
const auto& params = *req->GetParams();
protobuf::RequestHeader hdr;
@@ -168,7 +168,7 @@ void StorageApiRpcService::RPC_rpc_v1_send(FRT_RPCRequest* req) {
}
void StorageApiRpcService::encode_rpc_v1_response(FRT_RPCRequest& request, const api::StorageReply& reply) {
- LOG(info, "Server: encoding rpc.v1 response header and payload");
+ LOG(debug, "Server: encoding rpc.v1 response header and payload");
auto* ret = request.GetReturn();
// TODO skip encoding header altogether if no relevant fields set?
@@ -182,7 +182,7 @@ void StorageApiRpcService::encode_rpc_v1_response(FRT_RPCRequest& request, const
}
void StorageApiRpcService::send_rpc_v1_request(std::shared_ptr<api::StorageCommand> cmd) {
- LOG(info, "Client: sending rpc.v1 request for message of type %s", cmd->getType().getName().c_str());
+ LOG(debug, "Client: sending rpc.v1 request for message of type %s", cmd->getType().getName().c_str());
assert(cmd->getAddress() != nullptr);
auto target = _target_resolver->resolve_rpc_target(*cmd->getAddress());
@@ -247,14 +247,14 @@ void StorageApiRpcService::RequestDone(FRT_RPCRequest* raw_req) {
auto* req_ctx = static_cast<RpcRequestContext*>(req->GetContext()._value.VOIDP);
if (!req->CheckReturnTypes("bixbix")) {
api::ReturnCode error = map_frt_error_to_storage_api_error(*req, req_ctx->_timeout);
- LOG(info, "Client: received rpc.v1 error response: %s", error.toString().c_str());
+ LOG(debug, "Client: received rpc.v1 error response: %s", error.toString().c_str());
auto error_reply = req_ctx->_originator_cmd->makeReply();
error_reply->setResult(std::move(error));
// TODO needs tracing of received-event!
_message_dispatcher.dispatch_sync(std::move(error_reply));
return;
}
- LOG(info, "Client: received rpc.v1 OK response");
+ LOG(debug, "Client: received rpc.v1 OK response");
const auto& ret = *req->GetReturn();
protobuf::ResponseHeader hdr;