diff options
| author | Tor Brede Vekterli <vekterli@yahooinc.com> | 2023-05-08 11:57:06 +0000 |
|---|---|---|
| committer | Tor Brede Vekterli <vekterli@yahooinc.com> | 2023-05-08 12:25:37 +0000 |
| commit | bd86b6411dd1b4928074432817c6a9ebfe9c123c (patch) | |
| tree | 6f450ef6bc545d4ed191473191410ed9269e10ac /storage | |
| parent | 2558a5be5bbcddd4200af59ad4a3095b7e759668 (diff) | |
Default-enable fast path updates when document versions are consistent
This feature is always _implicitly_ enabled when 3-phase updates are
enabled (which is the case by default). Flip the config default to
true as well to be more in line with what's actually the case in
production.
Diffstat (limited to 'storage')
| -rw-r--r-- | storage/src/tests/distributor/distributor_stripe_test.cpp | 2 | ||||
| -rw-r--r-- | storage/src/vespa/storage/config/stor-distributormanager.def | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/storage/src/tests/distributor/distributor_stripe_test.cpp b/storage/src/tests/distributor/distributor_stripe_test.cpp index 2130c6ae62d..e963b505bc2 100644 --- a/storage/src/tests/distributor/distributor_stripe_test.cpp +++ b/storage/src/tests/distributor/distributor_stripe_test.cpp @@ -865,6 +865,8 @@ TEST_F(DistributorStripeTest, fast_path_on_consistent_gets_config_is_propagated_ { setup_stripe(Redundancy(1), NodeCount(1), "distributor:1 storage:1"); + EXPECT_TRUE(getConfig().update_fast_path_restart_enabled()); // Enabled by default + configure_update_fast_path_restart_enabled(true); EXPECT_TRUE(getConfig().update_fast_path_restart_enabled()); diff --git a/storage/src/vespa/storage/config/stor-distributormanager.def b/storage/src/vespa/storage/config/stor-distributormanager.def index fb0cd4f21d0..9d2a1ddf5c9 100644 --- a/storage/src/vespa/storage/config/stor-distributormanager.def +++ b/storage/src/vespa/storage/config/stor-distributormanager.def @@ -219,7 +219,7 @@ use_btree_database bool default=true restart ## content nodes, the two-phase update path reverts back to the regular fast path. ## Since all replicas of the document were in sync, applying the update in-place ## shall be considered safe. -restart_with_fast_update_path_if_all_get_timestamps_are_consistent bool default=false +restart_with_fast_update_path_if_all_get_timestamps_are_consistent bool default=true ## If set, no merge operations may be generated for any reason by a distributor. ## This is ONLY intended for system testing of certain transient edge cases and |