Remove notion of node-specific reliability from C++ distribution code

I have never seen this in use anywhere, and can find no code that ever
sets it. Bonus is that node candidate trimming can be vastly simplified.

1 files changed, 2 insertions, 10 deletions

diff --git a/storage/src/vespa/storage/storageserver/servicelayernode.cpp b/storage/src/vespa/storage/storageserver/servicelayernode.cpp
index c3cb1d8d6d6..15ff731d328 100644
--- a/storage/src/vespa/storage/storageserver/servicelayernode.cpp
+++ b/storage/src/vespa/storage/storageserver/servicelayernode.cpp
@@ -87,14 +87,12 @@ void
 ServiceLayerNode::initializeNodeSpecific()
 {
     // Give node state to mount point initialization, such that we can
-    // get capacity and reliability set in reported node state.
+    // get capacity set in reported node state.
     NodeStateUpdater::Lock::SP lock(_component->getStateUpdater().grabStateChangeLock());
     lib::NodeState ns(*_component->getStateUpdater().getReportedNodeState());
 
     ns.setCapacity(_serverConfig->nodeCapacity);
-    ns.setReliability(_serverConfig->nodeReliability);
-    LOG(debug, "Adjusting reported node state to include capacity and reliability: %s",
-        ns.toString().c_str());
+    LOG(debug, "Adjusting reported node state to include capacity: %s", ns.toString().c_str());
     _component->getStateUpdater().setReportedNodeState(ns);
 }
 
@@ -118,12 +116,6 @@ ServiceLayerNode::handleLiveConfigUpdate(const InitialGuard & initGuard)
                 ASSIGN(nodeCapacity);
                 ns.setCapacity(newC.nodeCapacity);
             }
-            if (DIFFER(nodeReliability)) {
-                LOG(info, "Live config update: Node reliability changed from %u to %u.",
-                    oldC.nodeReliability, newC.nodeReliability);
-                ASSIGN(nodeReliability);
-                ns.setReliability(newC.nodeReliability);
-            }
             if (updated) {
                 _serverConfig.reset(new vespa::config::content::core::StorServerConfig(oldC));
                 _component->getStateUpdater().setReportedNodeState(ns);