summaryrefslogtreecommitdiffstats
path: root/storage
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2020-05-05 12:04:54 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2020-05-05 12:04:54 +0000
commit11c7ca4c164bec4c0afbc2fec70b61ff8755ea7d (patch)
treefaa37b1e76f99be8fec2e92b666e45a60877865d /storage
parent3951cf1ed16f56674a28f4efbb7973bfbe4e7c6c (diff)
Update comments.
Diffstat (limited to 'storage')
-rw-r--r--storage/src/vespa/storage/persistence/persistencethread.cpp2
1 files changed, 2 insertions, 0 deletions
diff --git a/storage/src/vespa/storage/persistence/persistencethread.cpp b/storage/src/vespa/storage/persistence/persistencethread.cpp
index a77eea1073e..c53367c16f6 100644
--- a/storage/src/vespa/storage/persistence/persistencethread.cpp
+++ b/storage/src/vespa/storage/persistence/persistencethread.cpp
@@ -213,6 +213,7 @@ PersistenceThread::handleRemove(api::RemoveCommand& cmd, MessageTracker::UP trac
metrics.notFound.inc();
}
} else {
+ // Note that the &cmd capture is OK since its lifetime is guaranteed by the tracker
auto task = makeResultTask([&metrics, &cmd, tracker = std::move(trackerUP)](spi::Result::UP responseUP) {
const spi::RemoveResult & response = dynamic_cast<const spi::RemoveResult &>(*responseUP);
if (tracker->checkForError(response)) {
@@ -250,6 +251,7 @@ PersistenceThread::handleUpdate(api::UpdateCommand& cmd, MessageTracker::UP trac
tracker.setReply(std::move(reply));
}
} else {
+ // Note that the &cmd capture is OK since its lifetime is guaranteed by the tracker
auto task = makeResultTask([&cmd, tracker = std::move(trackerUP)](spi::Result::UP responseUP) {
const spi::UpdateResult & response = dynamic_cast<const spi::UpdateResult &>(*responseUP);
if (tracker->checkForError(response)) {