diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2020-10-26 13:59:26 +0000 |
---|---|---|
committer | Henning Baldersheim <balder@yahoo-inc.com> | 2020-10-26 13:59:26 +0000 |
commit | 22f126bc61fd6bb16871132f95ec5073f69cedff (patch) | |
tree | 156d914106fa959973aba9f213121c4e3b25ab49 /storageapi | |
parent | 348a3e3e433b91edb7c2becbda255747fe8983c2 (diff) |
GC unused _maxBufferSize data member from ApplyBucketDiffReply
Diffstat (limited to 'storageapi')
-rw-r--r-- | storageapi/src/tests/mbusprot/storageprotocoltest.cpp | 1 | ||||
-rw-r--r-- | storageapi/src/vespa/storageapi/message/bucket.cpp | 6 | ||||
-rw-r--r-- | storageapi/src/vespa/storageapi/message/bucket.h | 4 |
3 files changed, 3 insertions, 8 deletions
diff --git a/storageapi/src/tests/mbusprot/storageprotocoltest.cpp b/storageapi/src/tests/mbusprot/storageprotocoltest.cpp index 636f9b1f701..d1de3bf5afb 100644 --- a/storageapi/src/tests/mbusprot/storageprotocoltest.cpp +++ b/storageapi/src/tests/mbusprot/storageprotocoltest.cpp @@ -698,7 +698,6 @@ TEST_P(StorageProtocolTest, apply_bucket_diff) { EXPECT_EQ(nodes, reply2->getNodes()); EXPECT_EQ(entries, reply2->getDiff()); - EXPECT_EQ(1234u, reply2->getMaxBufferSize()); } namespace { diff --git a/storageapi/src/vespa/storageapi/message/bucket.cpp b/storageapi/src/vespa/storageapi/message/bucket.cpp index 7b7ecf91e44..ced71f5326b 100644 --- a/storageapi/src/vespa/storageapi/message/bucket.cpp +++ b/storageapi/src/vespa/storageapi/message/bucket.cpp @@ -394,8 +394,7 @@ ApplyBucketDiffCommand::print(std::ostream& out, bool verbose, ApplyBucketDiffReply::ApplyBucketDiffReply(const ApplyBucketDiffCommand& cmd) : BucketInfoReply(cmd), _nodes(cmd.getNodes()), - _diff(cmd.getDiff()), - _maxBufferSize(cmd.getMaxBufferSize()) + _diff(cmd.getDiff()) {} ApplyBucketDiffReply::~ApplyBucketDiffReply() = default; @@ -416,8 +415,7 @@ ApplyBucketDiffReply::print(std::ostream& out, bool verbose, if (i != 0) out << ", "; out << _nodes[i]; } - out << ", max buffer size " << _maxBufferSize << " bytes" - << ", " << _diff.size() << " entries of " << totalSize << " bytes, " + out << _diff.size() << " entries of " << totalSize << " bytes, " << (100.0 * filled / _diff.size()) << " \% filled)"; if (_diff.empty()) { out << ", no entries"; diff --git a/storageapi/src/vespa/storageapi/message/bucket.h b/storageapi/src/vespa/storageapi/message/bucket.h index 2b09967d95b..eabe847c7e0 100644 --- a/storageapi/src/vespa/storageapi/message/bucket.h +++ b/storageapi/src/vespa/storageapi/message/bucket.h @@ -309,16 +309,14 @@ public: private: std::vector<Node> _nodes; std::vector<Entry> _diff; - uint32_t _maxBufferSize; public: explicit ApplyBucketDiffReply(const ApplyBucketDiffCommand& cmd); - ~ApplyBucketDiffReply(); + ~ApplyBucketDiffReply() override; const std::vector<Node>& getNodes() const { return _nodes; } const std::vector<Entry>& getDiff() const { return _diff; } std::vector<Entry>& getDiff() { return _diff; } - uint32_t getMaxBufferSize() const { return _maxBufferSize; } void print(std::ostream& out, bool verbose, const std::string& indent) const override; |