diff options
author | Tor Brede Vekterli <vekterli@verizonmedia.com> | 2020-04-17 19:24:56 +0000 |
---|---|---|
committer | Tor Brede Vekterli <vekterli@verizonmedia.com> | 2020-04-17 19:24:56 +0000 |
commit | 0aade2bf351d67e56eea952211ee28efc87d2f5f (patch) | |
tree | cc0789738d0040bf9c47482491bc8dc10044dedd /storageframework/src | |
parent | 5267eb646f5482464250d0d1d29855af65b0667e (diff) |
Remove test of error handling anti-pattern
Invariant violations should be assertions and not exceptions,
so no point in testing that this is handled gracefully.
Diffstat (limited to 'storageframework/src')
-rw-r--r-- | storageframework/src/tests/thread/tickingthreadtest.cpp | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/storageframework/src/tests/thread/tickingthreadtest.cpp b/storageframework/src/tests/thread/tickingthreadtest.cpp index c42a9c17283..f69f77e8a07 100644 --- a/storageframework/src/tests/thread/tickingthreadtest.cpp +++ b/storageframework/src/tests/thread/tickingthreadtest.cpp @@ -234,21 +234,6 @@ TEST(TickingThreadTest, test_lock_critical_ticks) } } -TEST(TickingThreadTest, test_fails_on_start_without_threads) -{ - TestComponentRegister testReg( - ComponentRegisterImpl::UP(new ComponentRegisterImpl)); - int threadCount = 0; - MyApp app(threadCount, true); - try{ - app.start(testReg.getThreadPoolImpl()); - FAIL() << "Expected starting without threads to fail"; - } catch (vespalib::Exception& e) { - EXPECT_EQ(vespalib::string("Makes no sense to start threadpool without threads"), - e.getMessage()); - } -} - namespace { RealClock clock; |