diff options
author | Arne Juul <arnej@yahoo-inc.com> | 2018-06-12 12:50:28 +0200 |
---|---|---|
committer | Arne Juul <arnej@yahoo-inc.com> | 2018-06-12 13:51:45 +0200 |
commit | 016e584f0ad5a071e13d75eb8ad5ddb46b8c54f5 (patch) | |
tree | 869d4e4a4c4b8a9f9ef691b2980009017dece9e6 /storageframework | |
parent | 22796dddd3dc025018093783328ac87535ffecd9 (diff) |
use LOG_ABORT not just abort()
* abort() has the unfortunate effect that nothing is seen in the log,
just an event (which is usually not displayed); so ops people don't
see that the program is crashing at all.
* LOG_ABORT("message") will log an error with the message (and the file
and line) before calling abort(), so it's easy to see what happened.
* add or move <vespa/log/log.h> include and LOG_SETUP lines before
LOG_ABORT is used (or included).
Diffstat (limited to 'storageframework')
-rw-r--r-- | storageframework/src/vespa/storageframework/defaultimplementation/thread/threadpoolimpl.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/storageframework/src/vespa/storageframework/defaultimplementation/thread/threadpoolimpl.cpp b/storageframework/src/vespa/storageframework/defaultimplementation/thread/threadpoolimpl.cpp index 09c805b2b85..affeae44c04 100644 --- a/storageframework/src/vespa/storageframework/defaultimplementation/thread/threadpoolimpl.cpp +++ b/storageframework/src/vespa/storageframework/defaultimplementation/thread/threadpoolimpl.cpp @@ -4,6 +4,8 @@ #include "threadimpl.h" #include <vespa/vespalib/util/exceptions.h> #include <thread> +#include <vespa/log/log.h> +LOG_SETUP(".storageframework.thread_pool_impl"); using namespace std::chrono_literals; using vespalib::IllegalStateException; @@ -36,7 +38,7 @@ ThreadPoolImpl::~ThreadPoolImpl() if (i > 1000) { fprintf(stderr, "Failed to kill thread pool. Threads won't die. (And if allowing thread pool object" " to be deleted this will create a segfault later)\n"); - abort(); + LOG_ABORT("should not be reached"); } std::this_thread::sleep_for(10ms); } |