diff options
| author | Arne Juul <arnej@yahoo-inc.com> | 2018-06-12 12:50:28 +0200 |
|---|---|---|
| committer | Arne Juul <arnej@yahoo-inc.com> | 2018-06-12 13:51:45 +0200 |
| commit | 016e584f0ad5a071e13d75eb8ad5ddb46b8c54f5 (patch) | |
| tree | 869d4e4a4c4b8a9f9ef691b2980009017dece9e6 /streamingvisitors | |
| parent | 22796dddd3dc025018093783328ac87535ffecd9 (diff) | |
use LOG_ABORT not just abort()
* abort() has the unfortunate effect that nothing is seen in the log,
just an event (which is usually not displayed); so ops people don't
see that the program is crashing at all.
* LOG_ABORT("message") will log an error with the message (and the file
and line) before calling abort(), so it's easy to see what happened.
* add or move <vespa/log/log.h> include and LOG_SETUP lines before
LOG_ABORT is used (or included).
Diffstat (limited to 'streamingvisitors')
| -rw-r--r-- | streamingvisitors/src/tests/searchvisitor/searchvisitor.cpp | 4 | ||||
| -rw-r--r-- | streamingvisitors/src/vespa/searchvisitor/searchvisitor.cpp | 6 |
2 files changed, 7 insertions, 3 deletions
diff --git a/streamingvisitors/src/tests/searchvisitor/searchvisitor.cpp b/streamingvisitors/src/tests/searchvisitor/searchvisitor.cpp index 67b662fb16b..19d67b623eb 100644 --- a/streamingvisitors/src/tests/searchvisitor/searchvisitor.cpp +++ b/streamingvisitors/src/tests/searchvisitor/searchvisitor.cpp @@ -1,4 +1,8 @@ // Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. + +#include <vespa/log/log.h> +LOG_SETUP("searchvisitor_test"); + #include <vespa/document/base/testdocrepo.h> #include <vespa/document/repo/documenttyperepo.h> #include <vespa/vespalib/testkit/testapp.h> diff --git a/streamingvisitors/src/vespa/searchvisitor/searchvisitor.cpp b/streamingvisitors/src/vespa/searchvisitor/searchvisitor.cpp index f42dfe5af98..f10d934bd2d 100644 --- a/streamingvisitors/src/vespa/searchvisitor/searchvisitor.cpp +++ b/streamingvisitors/src/vespa/searchvisitor/searchvisitor.cpp @@ -1,5 +1,8 @@ // Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. +#include <vespa/log/log.h> +LOG_SETUP(".visitor.instance.searchvisitor"); + #include "querytermdata.h" #include "searchenvironment.h" #include "searchvisitor.h" @@ -16,9 +19,6 @@ #include <vespa/vespalib/objects/nbostream.h> #include <vespa/vespalib/util/exceptions.h> -#include <vespa/log/log.h> -LOG_SETUP(".visitor.instance.searchvisitor"); - namespace storage { using vsm::DocsumFilter; |