diff options
author | Jon Marius Venstad <venstad@gmail.com> | 2021-08-25 09:15:36 +0200 |
---|---|---|
committer | Jon Marius Venstad <venstad@gmail.com> | 2021-08-25 09:15:36 +0200 |
commit | 3cae9ea05a93a1cb8bbd7bfd7e3e5e08013017a1 (patch) | |
tree | 78ba2998f1174bc52d09a1bc6177eeb1dc5437bb /vespa-feed-client | |
parent | fe557fc926fd40305d9f04f9fd749d39cfbc4ea1 (diff) |
Stable error count, improve metric names and formatting
Diffstat (limited to 'vespa-feed-client')
-rw-r--r-- | vespa-feed-client/src/main/java/ai/vespa/feed/client/BenchmarkingCluster.java | 11 | ||||
-rw-r--r-- | vespa-feed-client/src/main/java/ai/vespa/feed/client/OperationStats.java | 11 |
2 files changed, 17 insertions, 5 deletions
diff --git a/vespa-feed-client/src/main/java/ai/vespa/feed/client/BenchmarkingCluster.java b/vespa-feed-client/src/main/java/ai/vespa/feed/client/BenchmarkingCluster.java index 840219a6bf1..4a26508cd17 100644 --- a/vespa-feed-client/src/main/java/ai/vespa/feed/client/BenchmarkingCluster.java +++ b/vespa-feed-client/src/main/java/ai/vespa/feed/client/BenchmarkingCluster.java @@ -82,13 +82,14 @@ public class BenchmarkingCluster implements Cluster { if (responsesByCode[code] > 0) responses.put(code, responsesByCode[code]); - return new OperationStats(requests.get(), + long requests = this.requests.get(); + return new OperationStats(requests, responses, exceptions, - requests.get() - results, - this.responses == 0 ? 0 : totalLatencyMillis / this.responses, - minLatencyMillis, - maxLatencyMillis, + requests - results, + this.responses == 0 ? -1 : totalLatencyMillis / this.responses, + this.responses == 0 ? -1 : minLatencyMillis, + this.responses == 0 ? -1 : maxLatencyMillis, bytesSent, bytesReceived); } diff --git a/vespa-feed-client/src/main/java/ai/vespa/feed/client/OperationStats.java b/vespa-feed-client/src/main/java/ai/vespa/feed/client/OperationStats.java index abba0f15880..9740421d810 100644 --- a/vespa-feed-client/src/main/java/ai/vespa/feed/client/OperationStats.java +++ b/vespa-feed-client/src/main/java/ai/vespa/feed/client/OperationStats.java @@ -53,46 +53,57 @@ public class OperationStats { bytesReceived - initial.bytesReceived); } + /** Number of HTTP requests attempted. */ public long requests() { return requests; } + /** Number of HTTP responses received. */ public long responses() { return requests - inflight; } + /** Number of 200 OK HTTP responses received. */ public long successes() { return responsesByCode.getOrDefault(200, 0L); } + /** Number of HTTP responses by status code. */ public Map<Integer, Long> responsesByCode() { return responsesByCode; } + /** Number of exceptions (instead of responses). */ public long exceptions() { return exceptions; } + /** Number of attempted requests which haven't yielded a response or exception yet. */ public long inflight() { return inflight; } + /** Average request-response latency, or -1. */ public long averageLatencyMillis() { return averageLatencyMillis; } + /** Minimum request-response latency, or -1. */ public long minLatencyMillis() { return minLatencyMillis; } + /** Maximum request-response latency, or -1. */ public long maxLatencyMillis() { return maxLatencyMillis; } + /** Number of bytes sent, for HTTP requests with a response. */ public long bytesSent() { return bytesSent; } + /** Number of bytes received in HTTP responses. */ public long bytesReceived() { return bytesReceived; } |