Return permissions before calling listener

In the wild we have seen code which makes new send requests
from ther onCompletion implementation.
When permissions to send are not returned until onComplete
returns, this can lead to deadlock.

Returning permissions earlier removes this possibility
and seems semantically correct to me.

1 files changed, 4 insertions, 7 deletions

diff --git a/vespa-http-client/src/main/java/com/yahoo/vespa/http/client/core/operationProcessor/OperationProcessor.java b/vespa-http-client/src/main/java/com/yahoo/vespa/http/client/core/operationProcessor/OperationProcessor.java
index 37def9b9a54..7cea767f9ba 100644
--- a/vespa-http-client/src/main/java/com/yahoo/vespa/http/client/core/operationProcessor/OperationProcessor.java
+++ b/vespa-http-client/src/main/java/com/yahoo/vespa/http/client/core/operationProcessor/OperationProcessor.java
@@ -192,13 +192,10 @@ public class OperationProcessor {
         final Result result = process(endpointResult, clusterId);
 
         if (result != null) {
-            try {
-                resultCallback.onCompletion(result.getDocumentId(), result);
-                if (traceToStderr && result.hasLocalTrace()) {
-                    System.err.println(result.toString());
-                }
-            } finally {
-                incompleteResultsThrottler.resultReady(result.isSuccess());
+            incompleteResultsThrottler.resultReady(result.isSuccess());
+            resultCallback.onCompletion(result.getDocumentId(), result);
+            if (traceToStderr && result.hasLocalTrace()) {
+                System.err.println(result.toString());
             }
         }
     }