summaryrefslogtreecommitdiffstats
path: root/vespa-osgi-testrunner/src
diff options
context:
space:
mode:
authorJon Marius Venstad <venstad@gmail.com>2022-02-28 10:37:56 +0100
committerJon Marius Venstad <venstad@gmail.com>2022-02-28 10:37:56 +0100
commit9decc4edb71bc5fda62d04ccda49232c709ff46b (patch)
tree1fde98447e56545d2605decfe93c7a073f900b52 /vespa-osgi-testrunner/src
parenta89c8f289cc1868923e15ff1dc01cacbfc4e1ef5 (diff)
Temporarily let junit tests runner allow no tests, like before
Diffstat (limited to 'vespa-osgi-testrunner/src')
-rw-r--r--vespa-osgi-testrunner/src/main/java/com/yahoo/vespa/testrunner/TestReport.java2
-rw-r--r--vespa-osgi-testrunner/src/test/java/com/yahoo/vespa/testrunner/AggregateTestRunnerTest.java2
2 files changed, 2 insertions, 2 deletions
diff --git a/vespa-osgi-testrunner/src/main/java/com/yahoo/vespa/testrunner/TestReport.java b/vespa-osgi-testrunner/src/main/java/com/yahoo/vespa/testrunner/TestReport.java
index 4db5405029b..945b7603fe4 100644
--- a/vespa-osgi-testrunner/src/main/java/com/yahoo/vespa/testrunner/TestReport.java
+++ b/vespa-osgi-testrunner/src/main/java/com/yahoo/vespa/testrunner/TestReport.java
@@ -39,7 +39,7 @@ public class TestReport {
}
public TestRunner.Status status() {
- return failedCount > 0 ? FAILURE : inconclusiveCount > 0 ? INCONCLUSIVE : (successCount + abortedCount + ignoredCount) > 0 ? SUCCESS : NO_TESTS;
+ return failedCount > 0 ? FAILURE : inconclusiveCount > 0 ? INCONCLUSIVE : (successCount + abortedCount + ignoredCount) > -1 ? SUCCESS : NO_TESTS; // TODO: require at least one test
}
public static Builder builder(){
diff --git a/vespa-osgi-testrunner/src/test/java/com/yahoo/vespa/testrunner/AggregateTestRunnerTest.java b/vespa-osgi-testrunner/src/test/java/com/yahoo/vespa/testrunner/AggregateTestRunnerTest.java
index 1af012f0fb2..2881da774f5 100644
--- a/vespa-osgi-testrunner/src/test/java/com/yahoo/vespa/testrunner/AggregateTestRunnerTest.java
+++ b/vespa-osgi-testrunner/src/test/java/com/yahoo/vespa/testrunner/AggregateTestRunnerTest.java
@@ -147,7 +147,7 @@ class AggregateTestRunnerTest {
@Test
void testReportStatus() {
- assertEquals(NO_TESTS, TestReport.builder().build().status());
+ assertEquals(SUCCESS, TestReport.builder().build().status()); // TODO: require at least 1 test
assertEquals(SUCCESS, TestReport.builder().withSuccessCount(1).build().status());
assertEquals(INCONCLUSIVE, TestReport.builder().withSuccessCount(1).withInconclusiveCount(1).build().status());
assertEquals(FAILURE, TestReport.builder().withSuccessCount(1).withFailedCount(1).build().status());