summaryrefslogtreecommitdiffstats
path: root/vespaclient-container-plugin
diff options
context:
space:
mode:
authorJon Marius Venstad <venstad@gmail.com>2020-09-30 12:15:29 +0200
committerJon Marius Venstad <venstad@gmail.com>2020-09-30 12:15:29 +0200
commit27632e92ff8182e1df0763fe6a9382e88c76dbf9 (patch)
tree38cca057baae2ba44d652c191127f146d3c484cb /vespaclient-container-plugin
parent24bfeefd369bca807776105746959896d46300ce (diff)
Test client close during request handling
Diffstat (limited to 'vespaclient-container-plugin')
-rw-r--r--vespaclient-container-plugin/src/main/java/com/yahoo/document/restapi/resource/DocumentV1ApiHandler.java2
-rw-r--r--vespaclient-container-plugin/src/test/java/com/yahoo/document/restapi/resource/DocumentV1ApiTest.java7
2 files changed, 8 insertions, 1 deletions
diff --git a/vespaclient-container-plugin/src/main/java/com/yahoo/document/restapi/resource/DocumentV1ApiHandler.java b/vespaclient-container-plugin/src/main/java/com/yahoo/document/restapi/resource/DocumentV1ApiHandler.java
index ab221274634..809e3522652 100644
--- a/vespaclient-container-plugin/src/main/java/com/yahoo/document/restapi/resource/DocumentV1ApiHandler.java
+++ b/vespaclient-container-plugin/src/main/java/com/yahoo/document/restapi/resource/DocumentV1ApiHandler.java
@@ -87,7 +87,7 @@ public class DocumentV1ApiHandler extends AbstractRequestHandler {
private static final CompletionHandler logException = new CompletionHandler() {
@Override public void completed() { }
@Override public void failed(Throwable t) {
- log.log(WARNING, "Exception writing response data", t);
+ log.log(FINE, () -> "Exception writing or closing response data: " + Exceptions.toMessageString(t));
}
};
diff --git a/vespaclient-container-plugin/src/test/java/com/yahoo/document/restapi/resource/DocumentV1ApiTest.java b/vespaclient-container-plugin/src/test/java/com/yahoo/document/restapi/resource/DocumentV1ApiTest.java
index a2140337111..9554fa0a913 100644
--- a/vespaclient-container-plugin/src/test/java/com/yahoo/document/restapi/resource/DocumentV1ApiTest.java
+++ b/vespaclient-container-plugin/src/test/java/com/yahoo/document/restapi/resource/DocumentV1ApiTest.java
@@ -331,6 +331,13 @@ public class DocumentV1ApiTest {
response.readAll());
assertEquals(412, response.getStatus());
+ // Client close during processing gives empty body
+ response = driver.sendRequest("http://localhost/document/v1/space/music/number/1/two");
+ response.clientClose();
+ executor.lastOperationContext().error(TIMEOUT, "no dice");
+ assertEquals("", response.readAll());
+ assertEquals(504, response.getStatus());
+
// OPTIONS gets options
response = driver.sendRequest("https://localhost/document/v1/space/music/docid/one", OPTIONS);
assertEquals("", response.readAll());