Don't classify condition-not-met and not-found as success

1 files changed, 4 insertions, 2 deletions

diff --git a/vespaclient-container-plugin/src/main/java/com/yahoo/vespa/http/server/FeedReplyReader.java b/vespaclient-container-plugin/src/main/java/com/yahoo/vespa/http/server/FeedReplyReader.java
index 1422ec10b08..377e91f6490 100644
--- a/vespaclient-container-plugin/src/main/java/com/yahoo/vespa/http/server/FeedReplyReader.java
+++ b/vespaclient-container-plugin/src/main/java/com/yahoo/vespa/http/server/FeedReplyReader.java
@@ -53,11 +53,13 @@ public class FeedReplyReader implements ReplyHandler {
             enqueue(context, reply.getError(0).getMessage(), ErrorCode.ERROR, false, reply.getTrace());
         } else {
             metricsHelper.reportSuccessful(type, latencyInSeconds);
-            metric.add(MetricNames.SUCCEEDED, 1, null);
             if ( ! conditionMet)
                 metric.add(MetricNames.CONDITION_NOT_MET, 1, testAndSetMetricCtx);
-            if ( ! updateNotFound(reply))
+            else if ( ! updateNotFound(reply))
                 metric.add(MetricNames.NOT_FOUND, 1, null);
+            else
+                metric.add(MetricNames.SUCCEEDED, 1, null);
+
             enqueue(context, "Document processed.", ErrorCode.OK, !conditionMet, reply.getTrace());
         }
     }