summaryrefslogtreecommitdiffstats
path: root/vespaclient-container-plugin
diff options
context:
space:
mode:
authorJon Marius Venstad <venstad@gmail.com>2020-12-23 12:56:32 +0100
committerJon Marius Venstad <venstad@gmail.com>2020-12-30 11:59:56 +0100
commit7efd5dfa1111e0aa94b97fbca06852de95258aa5 (patch)
tree8e88711c3a6eb071f9c1db989f6a06c463879585 /vespaclient-container-plugin
parent7bf09c3200422d047100362c82de6e1fdf2b323c (diff)
Replace use of [Storage... with [Content... and avoid overriding config id
Diffstat (limited to 'vespaclient-container-plugin')
-rw-r--r--vespaclient-container-plugin/src/main/java/com/yahoo/document/restapi/resource/DocumentV1ApiHandler.java8
-rw-r--r--vespaclient-container-plugin/src/test/java/com/yahoo/document/restapi/resource/DocumentV1ApiTest.java11
2 files changed, 7 insertions, 12 deletions
diff --git a/vespaclient-container-plugin/src/main/java/com/yahoo/document/restapi/resource/DocumentV1ApiHandler.java b/vespaclient-container-plugin/src/main/java/com/yahoo/document/restapi/resource/DocumentV1ApiHandler.java
index 5a370209f1c..add255a801e 100644
--- a/vespaclient-container-plugin/src/main/java/com/yahoo/document/restapi/resource/DocumentV1ApiHandler.java
+++ b/vespaclient-container-plugin/src/main/java/com/yahoo/document/restapi/resource/DocumentV1ApiHandler.java
@@ -948,18 +948,15 @@ public class DocumentV1ApiHandler extends AbstractRequestHandler {
static class StorageCluster {
private final String name;
- private final String configId;
private final Map<String, String> documentBuckets;
- StorageCluster(String name, String configId, Map<String, String> documentBuckets) {
+ StorageCluster(String name, Map<String, String> documentBuckets) {
this.name = requireNonNull(name);
- this.configId = requireNonNull(configId);
this.documentBuckets = Map.copyOf(documentBuckets);
}
String name() { return name; }
- String configId() { return configId; }
- String route() { return "[Storage:cluster=" + name() + ";clusterconfigid=" + configId() + "]"; }
+ String route() { return "[Content:cluster=" + name() + "]"; }
Optional<String> bucketOf(String documentType) { return Optional.ofNullable(documentBuckets.get(documentType)); }
}
@@ -968,7 +965,6 @@ public class DocumentV1ApiHandler extends AbstractRequestHandler {
return clusters.storage().stream()
.collect(toUnmodifiableMap(storage -> storage.name(),
storage -> new StorageCluster(storage.name(),
- storage.configid(),
buckets.cluster(storage.name())
.documentType().entrySet().stream()
.collect(toMap(entry -> entry.getKey(),
diff --git a/vespaclient-container-plugin/src/test/java/com/yahoo/document/restapi/resource/DocumentV1ApiTest.java b/vespaclient-container-plugin/src/test/java/com/yahoo/document/restapi/resource/DocumentV1ApiTest.java
index 826821981ba..449daa4970a 100644
--- a/vespaclient-container-plugin/src/test/java/com/yahoo/document/restapi/resource/DocumentV1ApiTest.java
+++ b/vespaclient-container-plugin/src/test/java/com/yahoo/document/restapi/resource/DocumentV1ApiTest.java
@@ -113,7 +113,6 @@ public class DocumentV1ApiTest {
}
final Map<String, StorageCluster> clusters = Map.of("content", new StorageCluster("content",
- "config-id",
Map.of("music", "default")));
ManualClock clock;
MockDocumentAccess access;
@@ -139,7 +138,7 @@ public class DocumentV1ApiTest {
public void testResolveCluster() {
assertEquals("content",
DocumentV1ApiHandler.resolveCluster(Optional.empty(), clusters).name());
- assertEquals("[Storage:cluster=content;clusterconfigid=config-id]",
+ assertEquals("[Content:cluster=content]",
DocumentV1ApiHandler.resolveCluster(Optional.of("content"), clusters).route());
try {
DocumentV1ApiHandler.resolveCluster(Optional.empty(), Map.of());
@@ -157,8 +156,8 @@ public class DocumentV1ApiTest {
}
try {
Map<String, StorageCluster> twoClusters = new TreeMap<>();
- twoClusters.put("one", new StorageCluster("one", "one-config", Map.of()));
- twoClusters.put("two", new StorageCluster("two", "two-config", Map.of()));
+ twoClusters.put("one", new StorageCluster("one", Map.of()));
+ twoClusters.put("two", new StorageCluster("two", Map.of()));
DocumentV1ApiHandler.resolveCluster(Optional.empty(), twoClusters);
fail("More than one cluster and no document type should fail");
}
@@ -193,7 +192,7 @@ public class DocumentV1ApiTest {
// GET at root is a visit. Numeric parameters have an upper bound.
access.expect(parameters -> {
- assertEquals("[Storage:cluster=content;clusterconfigid=config-id]", parameters.getRoute().toString());
+ assertEquals("[Content:cluster=content]", parameters.getRoute().toString());
assertEquals("default", parameters.getBucketSpace());
assertEquals(1024, parameters.getMaxTotalHits());
assertEquals(100, ((StaticThrottlePolicy) parameters.getThrottlePolicy()).getMaxPendingCount());
@@ -275,7 +274,7 @@ public class DocumentV1ApiTest {
// GET with full document ID is a document get operation which returns 404 when no document is found
access.session.expect((id, parameters) -> {
assertEquals(doc1.getId(), id);
- assertEquals(parameters().withRoute("[Storage:cluster=content;clusterconfigid=config-id]").withFieldSet("go"), parameters);
+ assertEquals(parameters().withRoute("[Content:cluster=content]").withFieldSet("go"), parameters);
parameters.responseHandler().get().handleResponse(new DocumentResponse(0, null));
return new Result(Result.ResultType.SUCCESS, null);
});