Revert "Revert "Emit a success factor from maintainers""

This reverts commit cd1b747b4f65fa3a6ed6aace23235db7591638c5.

1 files changed, 19 insertions, 9 deletions

diff --git a/vespajlib/src/test/java/com/yahoo/concurrent/maintenance/MaintainerTest.java b/vespajlib/src/test/java/com/yahoo/concurrent/maintenance/MaintainerTest.java
index e881d4b3ff6..d2db380f4a1 100644
--- a/vespajlib/src/test/java/com/yahoo/concurrent/maintenance/MaintainerTest.java
+++ b/vespajlib/src/test/java/com/yahoo/concurrent/maintenance/MaintainerTest.java
@@ -42,35 +42,45 @@ public class MaintainerTest {
 
     @Test
     public void success_metric() {
-        AtomicLong consecutiveFailures = new AtomicLong();
-        JobMetrics jobMetrics = new JobMetrics((job, count) -> consecutiveFailures.set(count));
+        TestJobMetrics jobMetrics = new TestJobMetrics();
         TestMaintainer maintainer = new TestMaintainer(null, jobControl, jobMetrics);
 
         // Maintainer fails twice in a row
         maintainer.successOnNextRun(false).run();
-        assertEquals(1, consecutiveFailures.get());
+        assertEquals(1, jobMetrics.consecutiveFailures.get());
         maintainer.successOnNextRun(false).run();
-        assertEquals(2, consecutiveFailures.get());
+        assertEquals(2, jobMetrics.consecutiveFailures.get());
 
         // Maintainer runs successfully
         maintainer.successOnNextRun(true).run();
-        assertEquals(0, consecutiveFailures.get());
+        assertEquals(0, jobMetrics.consecutiveFailures.get());
 
         // Maintainer runs successfully again
         maintainer.run();
-        assertEquals(0, consecutiveFailures.get());
+        assertEquals(0, jobMetrics.consecutiveFailures.get());
 
         // Maintainer throws
         maintainer.throwOnNextRun(new RuntimeException()).run();
-        assertEquals(1, consecutiveFailures.get());
+        assertEquals(1, jobMetrics.consecutiveFailures.get());
 
         // Maintainer recovers
         maintainer.throwOnNextRun(null).run();
-        assertEquals(0, consecutiveFailures.get());
+        assertEquals(0, jobMetrics.consecutiveFailures.get());
 
         // Lock exception is treated as a failure
         maintainer.throwOnNextRun(new UncheckedTimeoutException()).run();
-        assertEquals(1, consecutiveFailures.get());
+        assertEquals(1, jobMetrics.consecutiveFailures.get());
+    }
+
+    private static class TestJobMetrics extends JobMetrics {
+
+        AtomicLong consecutiveFailures = new AtomicLong();
+
+        @Override
+        protected void recordCompletion(String job, Long incompleteRuns, double successFactor) {
+            consecutiveFailures.set(incompleteRuns);
+        }
+
     }
 
 }