Make failure be the default when reporting success factor

2 files changed, 3 insertions, 3 deletions

diff --git a/vespajlib/src/main/java/com/yahoo/concurrent/maintenance/Maintainer.java b/vespajlib/src/main/java/com/yahoo/concurrent/maintenance/Maintainer.java
index 150021091ca..cd61c7ca250 100644
--- a/vespajlib/src/main/java/com/yahoo/concurrent/maintenance/Maintainer.java
+++ b/vespajlib/src/main/java/com/yahoo/concurrent/maintenance/Maintainer.java
@@ -117,7 +117,7 @@ public abstract class Maintainer implements Runnable {
         if (!force && !jobControl.isActive(name())) return;
         log.log(Level.FINE, () -> "Running " + this.getClass().getSimpleName());
 
-        double successFactorDeviation = 0;
+        double successFactorDeviation = -1;
         long startTime = clock.millis();
         try (var lock = jobControl.lockJob(name())) {
             successFactorDeviation = maintain();
diff --git a/vespajlib/src/test/java/com/yahoo/concurrent/maintenance/MaintainerTest.java b/vespajlib/src/test/java/com/yahoo/concurrent/maintenance/MaintainerTest.java
index bb62b1189a1..cdb5e36a455 100644
--- a/vespajlib/src/test/java/com/yahoo/concurrent/maintenance/MaintainerTest.java
+++ b/vespajlib/src/test/java/com/yahoo/concurrent/maintenance/MaintainerTest.java
@@ -55,7 +55,7 @@ public class MaintainerTest {
 
         // Maintainer throws
         maintainer.throwOnNextRun(new RuntimeException()).run();
-        assertEquals(0, jobMetrics.successFactor, delta);
+        assertEquals(-1, jobMetrics.successFactor, delta);
 
         // Maintainer recovers
         maintainer.throwOnNextRun(null).run();
@@ -64,7 +64,7 @@ public class MaintainerTest {
 
         // Lock exception is treated as a failure
         maintainer.throwOnNextRun(new UncheckedTimeoutException()).run();
-        assertEquals(0, jobMetrics.successFactor, delta);
+        assertEquals(-1, jobMetrics.successFactor, delta);
     }
 
     private static class TestJobMetrics extends JobMetrics {