summaryrefslogtreecommitdiffstats
path: root/vespajlib
diff options
context:
space:
mode:
authorbjormel <bjormel@yahooinc.com>2023-06-09 13:11:46 +0200
committerbjormel <bjormel@yahooinc.com>2023-06-09 13:11:46 +0200
commit2730a604e7f13b7a1294f4772d3550c3f2198d3c (patch)
tree7ecb1baaa2ba6b9e838e8ea8d7aec08025f1e2a2 /vespajlib
parentd77bc2d649ffc21f0276e9e59884f0da791bae8d (diff)
Update Javadoc
Diffstat (limited to 'vespajlib')
-rw-r--r--vespajlib/src/main/java/com/yahoo/concurrent/maintenance/Maintainer.java9
1 files changed, 7 insertions, 2 deletions
diff --git a/vespajlib/src/main/java/com/yahoo/concurrent/maintenance/Maintainer.java b/vespajlib/src/main/java/com/yahoo/concurrent/maintenance/Maintainer.java
index cd61c7ca250..68af9aa0a49 100644
--- a/vespajlib/src/main/java/com/yahoo/concurrent/maintenance/Maintainer.java
+++ b/vespajlib/src/main/java/com/yahoo/concurrent/maintenance/Maintainer.java
@@ -97,13 +97,18 @@ public abstract class Maintainer implements Runnable {
/**
* Called once each time this maintenance job should run.
*
- * @return the degree to which the run was deviated from the successFactorBaseline - a number between -1 (no success), to 0 (complete success).
+ * @return the degree to which the run successFactor deviated from the successFactorBaseline
+ * - a number between -1 (no success), to 0 (complete success) measured against the
+ * successFactorBaseline, or higher if the success factor is higher than the successFactorBaseline.
+ * The default successFactorBaseline is 1.0.
+ * If a maintainer is expected to fail sometimes, the successFactorBaseline should be set to a lower value.
+ *
* Note that this indicates whether something is wrong, so e.g. if the call did nothing because it should do
* nothing, 0.0 should be returned.
*/
protected abstract double maintain();
- /** Convenience methods to convert attempts and failures into a success factor, and return */
+ /** Convenience methods to convert attempts and failures into a success factor deviation from the baseline, and return */
protected final double asSuccessFactorDeviation(int attempts, int failures) {
double factor = attempts == 0 ? 1.0 : 1 - (double)failures / attempts;
return new BigDecimal(factor - successFactorBaseline).setScale(2, RoundingMode.HALF_UP).doubleValue();