Use vespalib::string in TestAndSetCondition

Avoids some implicit conversions. Add `starts_with` to `vespalib::string`
and `vespalib::stringref` to allow drop-in replacement for Document API code.

1 files changed, 19 insertions, 0 deletions

diff --git a/vespalib/src/tests/stllike/string_test.cpp b/vespalib/src/tests/stllike/string_test.cpp
index de384bce9ad..d60380aa3ab 100644
--- a/vespalib/src/tests/stllike/string_test.cpp
+++ b/vespalib/src/tests/stllike/string_test.cpp
@@ -489,4 +489,23 @@ TEST("test that empty_string is shared and empty") {
     EXPECT_EQUAL(empty_string(), "");
 }
 
+TEST("starts_with has expected semantics for small_string") {
+    vespalib::string a("foobar");
+    EXPECT_TRUE(a.starts_with(""));
+    EXPECT_TRUE(a.starts_with("foo"));
+    EXPECT_TRUE(a.starts_with("foobar"));
+    EXPECT_FALSE(a.starts_with("foobarf"));
+    EXPECT_FALSE(a.starts_with("oobar"));
+}
+
+TEST("starts_with has expected semantics for stringref") {
+    vespalib::string a("foobar");
+    vespalib::stringref ar(a);
+    EXPECT_TRUE(ar.starts_with(""));
+    EXPECT_TRUE(ar.starts_with("foo"));
+    EXPECT_TRUE(ar.starts_with("foobar"));
+    EXPECT_FALSE(ar.starts_with("foobarf"));
+    EXPECT_FALSE(ar.starts_with("oobar"));
+}
+
 TEST_MAIN() { TEST_RUN_ALL(); }