diff options
| author | Tor Egge <Tor.Egge@yahooinc.com> | 2023-01-31 13:55:36 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-31 13:55:36 +0100 |
| commit | 040f391a10e2cfbaffa82c4ba8c24984e29e5d6e (patch) | |
| tree | bd099b00032eba13e361691674c3eec96d49cb16 /vespalib | |
| parent | aaf8508fda9b863426d55463e9b221875e261341 (diff) | |
| parent | a42caabd3dd49d8d2bf9897923746a480de1884f (diff) | |
Merge pull request #25815 from vespa-engine/toregge/use-snprintf-instead-of-sprintf
Use snprintf instead of sprintf.
Diffstat (limited to 'vespalib')
3 files changed, 4 insertions, 4 deletions
diff --git a/vespalib/src/tests/sequencedtaskexecutor/adaptive_sequenced_executor_test.cpp b/vespalib/src/tests/sequencedtaskexecutor/adaptive_sequenced_executor_test.cpp index 1a458f86232..627452e3760 100644 --- a/vespalib/src/tests/sequencedtaskexecutor/adaptive_sequenced_executor_test.cpp +++ b/vespalib/src/tests/sequencedtaskexecutor/adaptive_sequenced_executor_test.cpp @@ -160,7 +160,7 @@ vespalib::string makeAltComponentId(Fixture &f) char altComponentId[20]; ISequencedTaskExecutor::ExecutorId executorId0 = f._threads.getExecutorIdFromName(ZERO); for (tryCnt = 1; tryCnt < 100; ++tryCnt) { - sprintf(altComponentId, "%d", tryCnt); + snprintf(altComponentId, sizeof(altComponentId), "%d", tryCnt); if (f._threads.getExecutorIdFromName(altComponentId) == executorId0) { break; } diff --git a/vespalib/src/tests/sequencedtaskexecutor/sequencedtaskexecutor_test.cpp b/vespalib/src/tests/sequencedtaskexecutor/sequencedtaskexecutor_test.cpp index 705d6346e8c..4c547acc25f 100644 --- a/vespalib/src/tests/sequencedtaskexecutor/sequencedtaskexecutor_test.cpp +++ b/vespalib/src/tests/sequencedtaskexecutor/sequencedtaskexecutor_test.cpp @@ -187,7 +187,7 @@ makeAltComponentId(Fixture &f) char altComponentId[20]; ISequencedTaskExecutor::ExecutorId executorId0 = f._threads->getExecutorIdFromName(ZERO); for (tryCnt = 1; tryCnt < 100; ++tryCnt) { - sprintf(altComponentId, "%d", tryCnt); + snprintf(altComponentId, sizeof(altComponentId), "%d", tryCnt); if (f._threads->getExecutorIdFromName(altComponentId) == executorId0) { break; } diff --git a/vespalib/src/vespa/fastlib/io/bufferedfile.cpp b/vespalib/src/vespa/fastlib/io/bufferedfile.cpp index fa55d0be812..31ca735a0bb 100644 --- a/vespalib/src/vespa/fastlib/io/bufferedfile.cpp +++ b/vespalib/src/vespa/fastlib/io/bufferedfile.cpp @@ -185,8 +185,8 @@ Fast_BufferedFile::SetPosition(const int64_t s) } diff = _filepos - s; if ( !(((diff > 0l) || ((diff == 0l) && (_fileleft == 0l))) && (diff <= static_cast<int64_t>(_buf.size())))) { - char tmp[8196]; - sprintf(tmp, "diff %" PRId64 " _fileleft=%" PRId64 " _buflen=%zu", diff, _fileleft, _buf.size()); + char tmp[64]; + snprintf(tmp, sizeof(tmp), "diff %" PRId64 " _fileleft=%" PRId64 " _buflen=%zu", diff, _fileleft, _buf.size()); abort(); } } |