diff options
| author | Tor Brede Vekterli <vekterli@yahooinc.com> | 2022-03-28 15:22:24 +0000 |
|---|---|---|
| committer | Tor Brede Vekterli <vekterli@yahooinc.com> | 2022-04-05 12:03:30 +0000 |
| commit | 27bfabe66929330b7ec29f6a8dc492521ff54b44 (patch) | |
| tree | 0871b161d3926a9a92eb58f7e5a0932c8b7a6998 /vespalib | |
| parent | ee8203f827272ac9e87d5905e276f75f1e662b1d (diff) | |
Use unsigned for intermediate expressions to avoid signed overflow
Diffstat (limited to 'vespalib')
| -rw-r--r-- | vespalib/src/vespa/vespalib/util/fiddle.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/vespalib/src/vespa/vespalib/util/fiddle.h b/vespalib/src/vespa/vespalib/util/fiddle.h index 20a13ff4654..f4d2ac33695 100644 --- a/vespalib/src/vespa/vespalib/util/fiddle.h +++ b/vespalib/src/vespa/vespalib/util/fiddle.h @@ -24,8 +24,8 @@ uint32_t mix(uint32_t prefix, uint32_t suffix, uint32_t prefix_bits) { if (prefix_bits >= 32) { return prefix; } - uint32_t suffix_mask = (1 << (32 - prefix_bits)) - 1; - uint32_t prefix_mask = (0 - 1) - suffix_mask; + uint32_t suffix_mask = (1u << (32u - prefix_bits)) - 1u; + uint32_t prefix_mask = (0u - 1u) - suffix_mask; return (prefix & prefix_mask) | (suffix & suffix_mask); } |