diff options
author | Geir Storli <geirst@verizonmedia.com> | 2020-09-02 07:36:44 +0000 |
---|---|---|
committer | Geir Storli <geirst@verizonmedia.com> | 2020-09-02 07:36:44 +0000 |
commit | 34570bf83e8fd5ca1f4000929ea4735235b33367 (patch) | |
tree | a39827101ea57744c80fdf86bea2a9475ffd0882 /vespalib | |
parent | 1cce6c15c29e59200aa9db5e7b61da4fabc25cf3 (diff) |
Extra used bytes must also be accounted in allocated bytes when creating memory stats.
Diffstat (limited to 'vespalib')
-rw-r--r-- | vespalib/src/tests/datastore/datastore/datastore_test.cpp | 39 | ||||
-rw-r--r-- | vespalib/src/vespa/vespalib/datastore/datastorebase.cpp | 35 |
2 files changed, 41 insertions, 33 deletions
diff --git a/vespalib/src/tests/datastore/datastore/datastore_test.cpp b/vespalib/src/tests/datastore/datastore/datastore_test.cpp index 00da8835c06..448df2d24bd 100644 --- a/vespalib/src/tests/datastore/datastore/datastore_test.cpp +++ b/vespalib/src/tests/datastore/datastore/datastore_test.cpp @@ -23,25 +23,15 @@ private: using ParentType::_activeBufferIds; public: MyStore() {} - - void - holdBuffer(uint32_t bufferId) - { + void holdBuffer(uint32_t bufferId) { ParentType::holdBuffer(bufferId); } - - void - holdElem(EntryRef ref, uint64_t len) - { + void holdElem(EntryRef ref, uint64_t len) { ParentType::holdElem(ref, len); } - - void - transferHoldLists(generation_t generation) - { + void transferHoldLists(generation_t generation) { ParentType::transferHoldLists(generation); } - void trimElemHoldList(generation_t usedGen) override { ParentType::trimElemHoldList(usedGen); } @@ -54,13 +44,13 @@ public: void enableFreeLists() { ParentType::enableFreeLists(); } - - void - switchActiveBuffer() - { + void switchActiveBuffer() { ParentType::switchActiveBuffer(0, 0u); } size_t activeBufferId() const { return _activeBufferIds[0]; } + BufferState& get_active_buffer_state() { + return ParentType::getBufferState(activeBufferId()); + } }; @@ -454,6 +444,21 @@ TEST(DataStoreTest, require_that_memory_stats_are_calculated) m._freeBuffers = MyRef::numBuffers() - 1; m._holdBuffers = 0; assertMemStats(m, s.getMemStats()); + + { // increase extra used bytes + auto prev_stats = s.getMemStats(); + s.get_active_buffer_state().incExtraUsedBytes(50); + auto curr_stats = s.getMemStats(); + EXPECT_EQ(prev_stats._allocBytes + 50, curr_stats._allocBytes); + EXPECT_EQ(prev_stats._usedBytes + 50, curr_stats._usedBytes); + } + + { // increase extra hold bytes + auto prev_stats = s.getMemStats(); + s.get_active_buffer_state().incExtraHoldBytes(30); + auto curr_stats = s.getMemStats(); + EXPECT_EQ(prev_stats._holdBytes + 30, curr_stats._holdBytes); + } } TEST(DataStoreTest, require_that_memory_usage_is_calculated) diff --git a/vespalib/src/vespa/vespalib/datastore/datastorebase.cpp b/vespalib/src/vespa/vespalib/datastore/datastorebase.cpp index 4e68b10d76a..15135af67b5 100644 --- a/vespalib/src/vespa/vespalib/datastore/datastorebase.cpp +++ b/vespalib/src/vespa/vespalib/datastore/datastorebase.cpp @@ -271,6 +271,23 @@ DataStoreBase::disableElemHoldList() } } +namespace { + +void +add_buffer_state_to_mem_stats(const BufferState& state, size_t elementSize, DataStoreBase::MemStats& stats) +{ + size_t extra_used_bytes = state.getExtraUsedBytes(); + stats._allocElems += state.capacity(); + stats._usedElems += state.size(); + stats._deadElems += state.getDeadElems(); + stats._holdElems += state.getHoldElems(); + stats._allocBytes += (state.capacity() * elementSize) + extra_used_bytes; + stats._usedBytes += (state.size() * elementSize) + extra_used_bytes; + stats._deadBytes += state.getDeadElems() * elementSize; + stats._holdBytes += (state.getHoldElems() * elementSize) + state.getExtraHoldBytes(); +} + +} DataStoreBase::MemStats DataStoreBase::getMemStats() const @@ -285,25 +302,11 @@ DataStoreBase::getMemStats() const } else if (state == BufferState::ACTIVE) { size_t elementSize = typeHandler->elementSize(); ++stats._activeBuffers; - stats._allocElems += bState.capacity(); - stats._usedElems += bState.size(); - stats._deadElems += bState.getDeadElems(); - stats._holdElems += bState.getHoldElems(); - stats._allocBytes += bState.capacity() * elementSize; - stats._usedBytes += (bState.size() * elementSize) + bState.getExtraUsedBytes(); - stats._deadBytes += bState.getDeadElems() * elementSize; - stats._holdBytes += (bState.getHoldElems() * elementSize) + bState.getExtraHoldBytes(); + add_buffer_state_to_mem_stats(bState, elementSize, stats); } else if (state == BufferState::HOLD) { size_t elementSize = typeHandler->elementSize(); ++stats._holdBuffers; - stats._allocElems += bState.capacity(); - stats._usedElems += bState.size(); - stats._deadElems += bState.getDeadElems(); - stats._holdElems += bState.getHoldElems(); - stats._allocBytes += bState.capacity() * elementSize; - stats._usedBytes += (bState.size() * elementSize) + bState.getExtraUsedBytes(); - stats._deadBytes += bState.getDeadElems() * elementSize; - stats._holdBytes += (bState.getHoldElems() * elementSize) + bState.getExtraHoldBytes(); + add_buffer_state_to_mem_stats(bState, elementSize, stats); } else { LOG_ABORT("should not be reached"); } |