summaryrefslogtreecommitdiffstats
path: root/vespalog
diff options
context:
space:
mode:
authorTor Egge <Tor.Egge@online.no>2023-01-31 12:46:10 +0100
committerTor Egge <Tor.Egge@online.no>2023-01-31 12:46:10 +0100
commit8dca74eb0879fe0e530c783d74a355747422aeec (patch)
tree1558b0d553400bf7a4e14ec01e82358ba8cfd1fd /vespalog
parent82e48e07e3d93521dfc53993a30d7f25ded4a440 (diff)
Use snprintf instead of sprintf.
Diffstat (limited to 'vespalog')
-rw-r--r--vespalog/src/logger/runserver.cpp6
-rw-r--r--vespalog/src/test/threads/testthreads.cpp2
-rw-r--r--vespalog/src/vespa/log/control-file.cpp2
-rw-r--r--vespalog/src/vespa/log/log.cpp2
4 files changed, 6 insertions, 6 deletions
diff --git a/vespalog/src/logger/runserver.cpp b/vespalog/src/logger/runserver.cpp
index 7cec2be6f3f..bbc08142b12 100644
--- a/vespalog/src/logger/runserver.cpp
+++ b/vespalog/src/logger/runserver.cpp
@@ -110,7 +110,7 @@ PidFile::writePid()
std::_Exit(1);
}
char buf[100];
- sprintf(buf, "%d\n", getpid());
+ snprintf(buf, sizeof(buf), "%d\n", getpid());
int l = strlen(buf);
ssize_t didw = write(_fd, buf, l);
if (didw != l) {
@@ -211,7 +211,7 @@ int loop(const char *svc, char * const * run)
{
torun += " (pid ";
char buf[20];
- sprintf(buf, "%d", (int)child);
+ snprintf(buf, sizeof(buf), "%d", (int)child);
torun += buf;
torun += ")";
}
@@ -319,7 +319,7 @@ int loop(const char *svc, char * const * run)
LOG(debug, "got signal %d, sending to pid %d",
(int)lastsig, (int)child);
char why[256];
- sprintf(why, "got signal %d", (int)lastsig);
+ snprintf(why, sizeof(why), "got signal %d", (int)lastsig);
EV_STOPPING(torun.c_str(), why);
kill(child, lastsig);
unhandledsig = 0;
diff --git a/vespalog/src/test/threads/testthreads.cpp b/vespalog/src/test/threads/testthreads.cpp
index 8fab6bcd638..ed2683b5c35 100644
--- a/vespalog/src/test/threads/testthreads.cpp
+++ b/vespalog/src/test/threads/testthreads.cpp
@@ -103,7 +103,7 @@ ThreadTester::Main()
for (int i = 0; i < numWriters; i++) {
char filename[100];
- sprintf(filename, "empty.%d", i);
+ snprintf(filename, sizeof(filename), "empty.%d", i);
writers[i] = std::make_unique<FileThread>(filename);
pool.NewThread(writers[i].get());
}
diff --git a/vespalog/src/vespa/log/control-file.cpp b/vespalog/src/vespa/log/control-file.cpp
index 2096dd1531c..9c0827c561c 100644
--- a/vespalog/src/vespa/log/control-file.cpp
+++ b/vespalog/src/vespa/log/control-file.cpp
@@ -201,7 +201,7 @@ ControlFile::setPrefix(const char *prefix)
{
if (prefix && !hasPrefix() && _prefix) {
char buf[_maxPrefix + 1];
- sprintf(buf, "%.*s\n", _maxPrefix - 1, prefix);
+ snprintf(buf, _maxPrefix + 1, "%.*s\n", _maxPrefix - 1, prefix);
memcpy(_prefix, buf, strlen(buf));
msync(_mapBase, pageAlign(1), MS_ASYNC | MS_INVALIDATE);
}
diff --git a/vespalog/src/vespa/log/log.cpp b/vespalog/src/vespa/log/log.cpp
index 69d69b97874..7430815122d 100644
--- a/vespalog/src/vespa/log/log.cpp
+++ b/vespalog/src/vespa/log/log.cpp
@@ -208,7 +208,7 @@ Logger::setRcsId(const char *id)
}
assert(size_t(len + 8) < sizeof(_rcsId));
- sprintf(_rcsId, "(%.*s): ", (int)(end - start), start);
+ snprintf(_rcsId, sizeof(_rcsId), "(%.*s): ", (int)(end - start), start);
LOG(spam, "rcs id was set to '%s'", _rcsId);
return 0;
}