fixes after review

* always AddEmpty if assumptions fail
* no unneccessary return
* change logging to debug to match old code

1 files changed, 4 insertions, 5 deletions

diff --git a/vsm/src/vespa/vsm/vsm/docsumfilter.cpp b/vsm/src/vespa/vsm/vsm/docsumfilter.cpp
index e824ce1bff6..2c3e2e6e3c7 100644
--- a/vsm/src/vespa/vsm/vsm/docsumfilter.cpp
+++ b/vsm/src/vespa/vsm/vsm/docsumfilter.cpp
@@ -354,21 +354,20 @@ DocsumFilter::writeSlimeField(const DocsumFieldSpec & fieldSpec,
                         static_cast<const document::LiteralFieldValueB *>(converted.get());
                     vespalib::stringref s = lfv->getValueRef();
                     packer.AddLongString(s.c_str(), s.size());
-                    return;
                 } else {
                     vespalib::string s = converted->getAsString();
                     packer.AddLongString(s.c_str(), s.size());
-                    return;
                 }
             } else {
-                LOG(warning, "writeSlimeField: Could not convert value for field '%d'", fieldId.getId());
+                LOG(debug, "writeSlimeField: Could not convert value for field '%d'", fieldId.getId());
+                packer.AddEmpty();
             }
         } else {
-            LOG(warning, "writeSlimeField: Field value not set for field '%d'", fieldId.getId());
+            LOG(debug, "writeSlimeField: Field value not set for field '%d'", fieldId.getId());
             packer.AddEmpty();
         }
     } else {
-        LOG(warning, "writeSlimeField: Cannot handle this command");
+        LOG(debug, "writeSlimeField: Cannot handle this command");
         packer.AddEmpty();
     }
 }