diff options
author | Arne H Juul <arnej@yahoo-inc.com> | 2017-02-13 11:30:33 +0100 |
---|---|---|
committer | Arne H Juul <arnej@yahoo-inc.com> | 2017-02-13 11:30:33 +0100 |
commit | 30806bc1f0e32048745d87579bac800991f8ae0c (patch) | |
tree | a4a997fb15811366654c67a5d447301e59686769 /vsm | |
parent | 1902c64bba7c128f6984839183da1698e7e2afee (diff) |
fixes after review
* always AddEmpty if assumptions fail
* no unneccessary return
* change logging to debug to match old code
Diffstat (limited to 'vsm')
-rw-r--r-- | vsm/src/vespa/vsm/vsm/docsumfilter.cpp | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/vsm/src/vespa/vsm/vsm/docsumfilter.cpp b/vsm/src/vespa/vsm/vsm/docsumfilter.cpp index e824ce1bff6..2c3e2e6e3c7 100644 --- a/vsm/src/vespa/vsm/vsm/docsumfilter.cpp +++ b/vsm/src/vespa/vsm/vsm/docsumfilter.cpp @@ -354,21 +354,20 @@ DocsumFilter::writeSlimeField(const DocsumFieldSpec & fieldSpec, static_cast<const document::LiteralFieldValueB *>(converted.get()); vespalib::stringref s = lfv->getValueRef(); packer.AddLongString(s.c_str(), s.size()); - return; } else { vespalib::string s = converted->getAsString(); packer.AddLongString(s.c_str(), s.size()); - return; } } else { - LOG(warning, "writeSlimeField: Could not convert value for field '%d'", fieldId.getId()); + LOG(debug, "writeSlimeField: Could not convert value for field '%d'", fieldId.getId()); + packer.AddEmpty(); } } else { - LOG(warning, "writeSlimeField: Field value not set for field '%d'", fieldId.getId()); + LOG(debug, "writeSlimeField: Field value not set for field '%d'", fieldId.getId()); packer.AddEmpty(); } } else { - LOG(warning, "writeSlimeField: Cannot handle this command"); + LOG(debug, "writeSlimeField: Cannot handle this command"); packer.AddEmpty(); } } |