diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2020-08-11 23:29:08 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-08-11 23:29:08 +0200 |
commit | 5858a6cdae398b95360c5d031e56037799930895 (patch) | |
tree | 737668034aeebf3146b0e2d9229157101c116672 /yolean/src | |
parent | a9775442179fd17067cd351051d803920c0d74fc (diff) |
Revert "Reduce the use of hamcrest when normal assertEquals/assertTrue does a…"
Diffstat (limited to 'yolean/src')
4 files changed, 47 insertions, 48 deletions
diff --git a/yolean/src/test/java/com/yahoo/yolean/chain/ChainBuilderTest.java b/yolean/src/test/java/com/yahoo/yolean/chain/ChainBuilderTest.java index 70bb0ab1397..60629e05636 100644 --- a/yolean/src/test/java/com/yahoo/yolean/chain/ChainBuilderTest.java +++ b/yolean/src/test/java/com/yahoo/yolean/chain/ChainBuilderTest.java @@ -9,9 +9,9 @@ import java.util.List; import static com.yahoo.yolean.chain.Dependencies.after; import static com.yahoo.yolean.chain.Dependencies.before; import static com.yahoo.yolean.chain.Dependencies.provides; +import static org.hamcrest.CoreMatchers.is; import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.collection.IsIterableContainingInOrder.contains; -import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; /** @@ -100,7 +100,7 @@ public class ChainBuilderTest { public void build_empty_chain() { Chain<Filter> chain = getChain().build(); assertTrue(chain.isEmpty()); - assertEquals("myChain", chain.id()); + assertThat(chain.id(), is("myChain")); } @Test @@ -140,7 +140,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(b).add(a, before(b)).build(); - assertEquals(new Chain<>("myChain", a, b), chain); + assertThat(chain, is(new Chain<>("myChain", a, b))); } @Test @@ -151,7 +151,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(b, after(a)).add(a).build(); - assertEquals(new Chain<>("myChain", a, b), chain); + assertThat(chain, is(new Chain<>("myChain", a, b))); } @Test @@ -162,7 +162,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(b).add(a, before(b.getClass())).build(); - assertEquals(new Chain<>("myChain", a, b), chain); + assertThat(chain, is(new Chain<>("myChain", a, b))); } @Test @@ -173,7 +173,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(b, after(a.getClass())).add(a).build(); - assertEquals(new Chain<>("myChain", a, b), chain); + assertThat(chain, is(new Chain<>("myChain", a, b))); } @Test @@ -184,7 +184,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(b).add(a, before(FilterB.class)).build(); - assertEquals(new Chain<>("myChain", a, b), chain); + assertThat(chain, is(new Chain<>("myChain", a, b))); } @Test @@ -195,7 +195,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(b, after(FilterA.class)).add(a).build(); - assertEquals(new Chain<>("myChain", a, b), chain); + assertThat(chain, is(new Chain<>("myChain", a, b))); } @Test @@ -206,7 +206,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(b, provides("B")).add(a, before("B")).build(); - assertEquals(new Chain<>("myChain", a, b), chain); + assertThat(chain, is(new Chain<>("myChain", a, b))); } @Test @@ -217,7 +217,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(b, after("A")).add(a, provides("A")).build(); - assertEquals(new Chain<>("myChain", a, b), chain); + assertThat(chain, is(new Chain<>("myChain", a, b))); } @Test @@ -228,7 +228,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(providesA).add(beforeA).build(); - assertEquals(new Chain<>("myChain", beforeA, providesA), chain); + assertThat(chain, is(new Chain<>("myChain", beforeA, providesA))); } @Test @@ -239,7 +239,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(afterA).add(providesA).build(); - assertEquals(new Chain<>("myChain", providesA, afterA), chain); + assertThat(chain, is(new Chain<>("myChain", providesA, afterA))); } @Test @@ -250,7 +250,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(b).add(a, before("*")).build(); - assertEquals(new Chain<>("myChain", a, b), chain); + assertThat(chain, is(new Chain<>("myChain", a, b))); } @Test @@ -261,7 +261,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(b, after("*")).add(a).build(); - assertEquals(new Chain<>("myChain", a, b), chain); + assertThat(chain, is(new Chain<>("myChain", a, b))); } @Test @@ -272,7 +272,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(a).add(beforeAll).build(); - assertEquals(new Chain<>("myChain", beforeAll, a), chain); + assertThat(chain, is(new Chain<>("myChain", beforeAll, a))); } @Test @@ -283,7 +283,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(afterAll).add(a).build(); - assertEquals(new Chain<>("myChain", a, afterAll), chain); + assertThat(chain, is(new Chain<>("myChain", a, afterAll))); } @Test @@ -294,7 +294,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(beforeAll).add(beforeBeforeAll).build(); - assertEquals(new Chain<>("myChain", beforeBeforeAll, beforeAll), chain); + assertThat(chain, is(new Chain<>("myChain", beforeBeforeAll, beforeAll))); } @Test @@ -305,7 +305,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(afterAfterAll).add(afterAll).build(); - assertEquals(new Chain<>("myChain", afterAll, afterAfterAll), chain); + assertThat(chain, is(new Chain<>("myChain", afterAll, afterAfterAll))); } @Test @@ -316,7 +316,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(beforeAll).add(first, before("BeforeAll")).build(); - assertEquals(new Chain<>("myChain", first, beforeAll), chain); + assertThat(chain, is(new Chain<>("myChain", first, beforeAll))); } @Test @@ -327,7 +327,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(last, after("AfterAll")).add(afterAll).build(); - assertEquals(new Chain<>("myChain", afterAll, last), chain); + assertThat(chain, is(new Chain<>("myChain", afterAll, last))); } @Test @@ -338,7 +338,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(b, after(a.getClass().getName())).add(a).build(); - assertEquals(new Chain<>("myChain", a, b), chain); + assertThat(chain, is(new Chain<>("myChain", a, b))); } @Test @@ -350,7 +350,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(last, after("A")).add(first, before("A")).add(extendsA).build(); - assertEquals(new Chain<>("myChain", first, extendsA, last), chain); + assertThat(chain, is(new Chain<>("myChain", first, extendsA, last))); } @Test @@ -362,7 +362,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(last, after("A")).add(first, before("ExtendsA")).add(extendsA).build(); - assertEquals(new Chain<>("myChain", first, extendsA, last), chain); + assertThat(chain, is(new Chain<>("myChain", first, extendsA, last))); } @Test @@ -373,7 +373,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(A, before("*")).add(beforeA_and_beforeB).add(B).build(); - assertEquals(new Chain<>("myChain", beforeA_and_beforeB, A, B), chain); + assertThat(chain, is(new Chain<>("myChain", beforeA_and_beforeB, A, B))); } @Test @@ -385,7 +385,7 @@ public class ChainBuilderTest { Chain<Filter> chain = getChain(). add(a).add(c).add(b, after(a), before(c)).build(); - assertEquals(new Chain<>("myChain", a, b, c), chain); + assertThat(chain, is(new Chain<>("myChain", a, b, c))); } private ChainBuilder<Filter> getChain() { diff --git a/yolean/src/test/java/com/yahoo/yolean/chain/ChainTest.java b/yolean/src/test/java/com/yahoo/yolean/chain/ChainTest.java index da9ae2c38e3..aa344d88f5a 100644 --- a/yolean/src/test/java/com/yahoo/yolean/chain/ChainTest.java +++ b/yolean/src/test/java/com/yahoo/yolean/chain/ChainTest.java @@ -3,8 +3,9 @@ package com.yahoo.yolean.chain; import org.junit.Test; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertNotEquals; +import static org.hamcrest.CoreMatchers.is; +import static org.hamcrest.CoreMatchers.not; +import static org.junit.Assert.assertThat; /** * @author Tony Vaagenes @@ -22,33 +23,33 @@ public class ChainTest { @Test public void empty_chain_toString() { Chain<Filter> c = new Chain<>("myChain"); - assertEquals("chain 'myChain'{}", c.toString()); + assertThat(c.toString(), is("chain 'myChain'{}")); } @Test public void singleton_chain_toString() { Chain<Filter> c = new Chain<>("myChain", new Filter()); - assertEquals("chain 'myChain'{ Filter }", c.toString()); + assertThat(c.toString(), is("chain 'myChain'{ Filter }")); } @Test public void chain_toString() { Chain<Filter> c = new Chain<>("myChain", new Filter(), new Filter(), new OtherFilter()); - assertEquals("chain 'myChain'{ Filter -> Filter -> OtherFilter }", c.toString()); + assertThat(c.toString(), is("chain 'myChain'{ Filter -> Filter -> OtherFilter }")); } @Test public void non_equal_due_to_different_components() { - assertNotEquals(new Chain<>("a", new Filter()), new Chain<>("a", new Filter())); + assertThat(new Chain<>("a", new Filter()), is(not(new Chain<>("a", new Filter())))); } @Test public void non_equal_due_to_different_size_comopnents() { - assertNotEquals(new Chain<>("a", new Filter()), new Chain<Filter>("a")); + assertThat(new Chain<>("a", new Filter()), is(not(new Chain<Filter>("a")))); } @Test public void hashCode_equals() { - assertEquals(new Chain<>("a").hashCode(), new Chain<Filter>("a").hashCode()); + assertThat(new Chain<>("a").hashCode(), is(new Chain<Filter>("a").hashCode())); } } diff --git a/yolean/src/test/java/com/yahoo/yolean/chain/DirectedGraphTest.java b/yolean/src/test/java/com/yahoo/yolean/chain/DirectedGraphTest.java index b37c57b536b..0ff600430b6 100644 --- a/yolean/src/test/java/com/yahoo/yolean/chain/DirectedGraphTest.java +++ b/yolean/src/test/java/com/yahoo/yolean/chain/DirectedGraphTest.java @@ -4,14 +4,13 @@ package com.yahoo.yolean.chain; import org.junit.Before; import org.junit.Test; -import java.util.Arrays; - -import static org.junit.Assert.assertTrue; +import static org.hamcrest.collection.IsIterableContainingInOrder.contains; +import static org.junit.Assert.assertThat; public class DirectedGraphTest { private DirectedGraph graph; - private final Vertex[] v = new Vertex[10]; + private Vertex[] v = new Vertex[10]; @Before public void setup() { @@ -27,7 +26,7 @@ public class DirectedGraphTest { graph.addVertex(v[0]); graph.addBeginningVertex(v[1]); - assertTrue(graph.topologicalSort().containsAll(Arrays.asList(v[1], v[0]))); + assertThat(graph.topologicalSort(), contains(v[1], v[0])); } @Test @@ -36,7 +35,7 @@ public class DirectedGraphTest { graph.addBeginningVertex(v[1]); graph.addEdge(v[0], v[1]); - assertTrue(graph.topologicalSort().containsAll(Arrays.asList(v[0], v[1]))); + assertThat(graph.topologicalSort(), contains(v[0], v[1])); } static class TestVertex implements Vertex { diff --git a/yolean/src/test/java/com/yahoo/yolean/chain/EnumeratedIdentitySetTest.java b/yolean/src/test/java/com/yahoo/yolean/chain/EnumeratedIdentitySetTest.java index 5f0692e186f..aded98914c5 100644 --- a/yolean/src/test/java/com/yahoo/yolean/chain/EnumeratedIdentitySetTest.java +++ b/yolean/src/test/java/com/yahoo/yolean/chain/EnumeratedIdentitySetTest.java @@ -16,7 +16,6 @@ import static java.util.Collections.singleton; import static org.hamcrest.CoreMatchers.is; import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.collection.IsEmptyCollection.empty; -import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertSame; import static org.junit.Assert.assertTrue; @@ -38,13 +37,13 @@ public class EnumeratedIdentitySetTest { @Test public void size() { EnumeratedIdentitySet<Element> set = new EnumeratedIdentitySet<>(elements); - assertEquals(elements.size(), set.size()); + assertThat(set.size(), is(elements.size())); set.add(elements.get(0)); - assertEquals(elements.size(), set.size()); + assertThat(set.size(), is(elements.size())); set.remove(elements.get(0)); - assertEquals(elements.size() - 1, set.size()); + assertThat(set.size(), is(elements.size() - 1)); } @Test @@ -74,8 +73,8 @@ public class EnumeratedIdentitySetTest { count++; } - assertEquals(count, collectedElements.size()); - assertEquals(elements.size(), collectedElements.size()); + assertThat(collectedElements.size(), is(count)); + assertThat(collectedElements.size(), is(elements.size())); for (Element element : elements) { assertTrue(collectedElements.containsKey(element)); @@ -151,7 +150,7 @@ public class EnumeratedIdentitySetTest { public void clear() { EnumeratedIdentitySet<Element> set = new EnumeratedIdentitySet<>(elements); set.clear(); - assertTrue(set.isEmpty()); + assertThat(set, empty()); } @Test @@ -196,7 +195,7 @@ public class EnumeratedIdentitySetTest { } List<Element> forceRenumber = set.insertionOrderedList(); - assertEquals(elements.size(), forceRenumber.size()); + assertThat(forceRenumber.size(), is(elements.size())); for (int i = 0; i < elements.size(); i++) { assertSame(forceRenumber.get(i), elements.get(i)); @@ -215,7 +214,7 @@ public class EnumeratedIdentitySetTest { } set.insertionOrderedList(); - assertTrue(set.numbers().isEmpty()); + assertThat(set.numbers(), empty()); set.add(new Element()); assertThat(set.numbers(), containsSameElements(singleton(0))); |