diff options
author | Håkon Hallingstad <hakon@verizonmedia.com> | 2020-11-11 11:39:45 +0100 |
---|---|---|
committer | Håkon Hallingstad <hakon@verizonmedia.com> | 2020-11-11 11:39:45 +0100 |
commit | c42e7d92ccbedfd6cf2888ea075e420fb9bef85a (patch) | |
tree | 95bcb3cc1cce2b9d53d66ca36fbbcc57c9894f80 /zkfacade | |
parent | bc5622d890eeefd7a180f1c057a6a41ca9614ed5 (diff) |
return earlier if possible
Diffstat (limited to 'zkfacade')
-rw-r--r-- | zkfacade/src/main/java/com/yahoo/vespa/curator/stats/ThreadLockStats.java | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/zkfacade/src/main/java/com/yahoo/vespa/curator/stats/ThreadLockStats.java b/zkfacade/src/main/java/com/yahoo/vespa/curator/stats/ThreadLockStats.java index 73ce731390d..6438dcb77b7 100644 --- a/zkfacade/src/main/java/com/yahoo/vespa/curator/stats/ThreadLockStats.java +++ b/zkfacade/src/main/java/com/yahoo/vespa/curator/stats/ThreadLockStats.java @@ -181,15 +181,16 @@ public class ThreadLockStats { } Thread threadHoldingLockPath = threadLockStats.get().thread; + if (threadAcquiringLockPath == threadHoldingLockPath) { + // reentry + return; + } + errorMessage.append(", trying to acquire lock ") .append(lockPath) .append(" held by thread ") .append(threadHoldingLockPath.getName()); - - if (threadAcquiringLockPath == threadHoldingLockPath) { - // reentry - return; - } else if (threadsAcquiring.contains(threadHoldingLockPath)) { + if (threadsAcquiring.contains(threadHoldingLockPath)) { // deadlock getGlobalLockMetrics(pathToAcquire).incrementDeadlockCount(); logger.warning(errorMessage.toString()); |