summaryrefslogtreecommitdiffstats
path: root/zkfacade
diff options
context:
space:
mode:
authorHarald Musum <musum@verizonmedia.com>2020-05-25 13:06:38 +0200
committerHarald Musum <musum@verizonmedia.com>2020-05-25 13:06:38 +0200
commitf00a7bedf30b5f8dc825ed499fd4ea14188f738b (patch)
tree53e208942a1e2704419584c503b144b0b510576a /zkfacade
parent5f47dcd8333b99aeef31e103688f502c6053827b (diff)
Do not wait longer for more participants in barrier
Diffstat (limited to 'zkfacade')
-rw-r--r--zkfacade/src/main/java/com/yahoo/vespa/curator/CuratorCompletionWaiter.java13
1 files changed, 2 insertions, 11 deletions
diff --git a/zkfacade/src/main/java/com/yahoo/vespa/curator/CuratorCompletionWaiter.java b/zkfacade/src/main/java/com/yahoo/vespa/curator/CuratorCompletionWaiter.java
index 537ec2ae751..05582d6bbda 100644
--- a/zkfacade/src/main/java/com/yahoo/vespa/curator/CuratorCompletionWaiter.java
+++ b/zkfacade/src/main/java/com/yahoo/vespa/curator/CuratorCompletionWaiter.java
@@ -62,13 +62,8 @@ class CuratorCompletionWaiter implements Curator.CompletionWaiter {
log.log(Level.FINE, barrierCompletedMessage(respondents, startTime));
break;
}
- // Then, if some are missing after 2 seconds, allow if the server this code is running on is one of the repondents
- if (usedMoreTimeThan(Duration.ofSeconds(2), startTime) && respondents.contains(myId) && respondents.size() >= barrierMemberCount()) {
- log.log(Level.INFO, barrierCompletedMessage(respondents, startTime));
- break;
- }
- // If some are still missing after 4 seconds, quorum is enough
- if (usedMoreTimeThan(Duration.ofSeconds(4), startTime) && respondents.size() >= barrierMemberCount()) {
+ // If some are missing, quorum is enough
+ if (respondents.size() >= barrierMemberCount()) {
log.log(Level.INFO, barrierCompletedMessage(respondents, startTime));
break;
}
@@ -79,10 +74,6 @@ class CuratorCompletionWaiter implements Curator.CompletionWaiter {
return respondents;
}
- private boolean usedMoreTimeThan(Duration waitTime, Instant startTime) {
- return clock.instant().isAfter(startTime.plus(waitTime));
- }
-
private String barrierCompletedMessage(List<String> respondents, Instant startTime) {
return barrierPath + " completed in " + Duration.between(startTime, Instant.now()).toString() +
", " + respondents.size() + "/" + curator.zooKeeperEnsembleCount() + " responded: " + respondents;