diff options
author | Harald Musum <musum@yahooinc.com> | 2024-04-06 10:39:00 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-04-06 10:39:00 +0200 |
commit | 0decf39813d495b2531c95307a50c87e3043da01 (patch) | |
tree | 755dcdaaaf0b4ad8917eeb41c55559f99fb6d998 /zookeeper-server/zookeeper-server | |
parent | 9059f0cb7aeb047097c5e732410d376553db8cce (diff) |
Revert "- Use default compilerArgs where we turn on linting and enable warnin…" (#30840)
Diffstat (limited to 'zookeeper-server/zookeeper-server')
-rw-r--r-- | zookeeper-server/zookeeper-server/pom.xml | 11 | ||||
-rw-r--r-- | zookeeper-server/zookeeper-server/src/main/java/com/yahoo/vespa/zookeeper/VespaZooKeeperAdminImpl.java | 2 |
2 files changed, 5 insertions, 8 deletions
diff --git a/zookeeper-server/zookeeper-server/pom.xml b/zookeeper-server/zookeeper-server/pom.xml index 267a43e62be..bb4a819b5ac 100644 --- a/zookeeper-server/zookeeper-server/pom.xml +++ b/zookeeper-server/zookeeper-server/pom.xml @@ -66,18 +66,17 @@ <artifactId>snappy-java</artifactId> <scope>compile</scope> </dependency> - <dependency> - <!-- Included to suppress warning on missing annotation 'edu.umd.cs.findbugs.annotations.SuppressFBWarnings' at compile time --> - <groupId>com.github.spotbugs</groupId> - <artifactId>spotbugs-annotations</artifactId> - <scope>compile</scope> - </dependency> </dependencies> <build> <plugins> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-compiler-plugin</artifactId> + <configuration> + <compilerArgs> + <arg>-Xlint:all</arg> + </compilerArgs> + </configuration> </plugin> <plugin> <groupId>org.apache.maven.plugins</groupId> diff --git a/zookeeper-server/zookeeper-server/src/main/java/com/yahoo/vespa/zookeeper/VespaZooKeeperAdminImpl.java b/zookeeper-server/zookeeper-server/src/main/java/com/yahoo/vespa/zookeeper/VespaZooKeeperAdminImpl.java index 891a35582b3..1f15c758583 100644 --- a/zookeeper-server/zookeeper-server/src/main/java/com/yahoo/vespa/zookeeper/VespaZooKeeperAdminImpl.java +++ b/zookeeper-server/zookeeper-server/src/main/java/com/yahoo/vespa/zookeeper/VespaZooKeeperAdminImpl.java @@ -26,7 +26,6 @@ public class VespaZooKeeperAdminImpl implements VespaZooKeeperAdmin { private static final Logger log = java.util.logging.Logger.getLogger(VespaZooKeeperAdminImpl.class.getName()); - @SuppressWarnings("try") @Override public void reconfigure(String connectionSpec, String servers) throws ReconfigException { try (ZooKeeperAdmin zooKeeperAdmin = createAdmin(connectionSpec)) { @@ -59,7 +58,6 @@ public class VespaZooKeeperAdminImpl implements VespaZooKeeperAdmin { } /** Creates a node in zookeeper, with hostname as part of node name, this ensures that server is up and working before returning */ - @SuppressWarnings("try") void createDummyNode(ZookeeperServerConfig zookeeperServerConfig) { int sleepTime = 2_000; try (ZooKeeperAdmin zooKeeperAdmin = createAdmin(localConnectionSpec(zookeeperServerConfig))) { |