summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--searchsummary/src/vespa/searchsummary/docsummary/docsumwriter.cpp2
-rw-r--r--searchsummary/src/vespa/searchsummary/docsummary/docsumwriter.h2
2 files changed, 3 insertions, 1 deletions
diff --git a/searchsummary/src/vespa/searchsummary/docsummary/docsumwriter.cpp b/searchsummary/src/vespa/searchsummary/docsummary/docsumwriter.cpp
index b05f80b5db1..c2f4848fdc7 100644
--- a/searchsummary/src/vespa/searchsummary/docsummary/docsumwriter.cpp
+++ b/searchsummary/src/vespa/searchsummary/docsummary/docsumwriter.cpp
@@ -167,8 +167,10 @@ DynamicDocsumWriter::insertDocsum(const ResolveClassInfo & rci,
const Memory field_name(outCfg->_bindname.data(), outCfg->_bindname.size());
ObjectInserter inserter(docsum, field_name);
if (writer != nullptr) {
+ //TODO: Vespa 7 Need to add test for writer->isDefaultValue
writer->insertField(docid, &gres, state, outCfg->_type, inserter);
} else {
+ //TODO: Vespa 7 Need to add similar test as writer->isDefaultValue
if (rci.inputClass == rci.outputClass) {
convertEntry(state, outCfg, gres.GetEntry(i), inserter, slime);
} else {
diff --git a/searchsummary/src/vespa/searchsummary/docsummary/docsumwriter.h b/searchsummary/src/vespa/searchsummary/docsummary/docsumwriter.h
index 45094cdc056..2e409565306 100644
--- a/searchsummary/src/vespa/searchsummary/docsummary/docsumwriter.h
+++ b/searchsummary/src/vespa/searchsummary/docsummary/docsumwriter.h
@@ -86,7 +86,7 @@ private:
public:
DynamicDocsumWriter(ResultConfig *config, KeywordExtractor *extractor);
- virtual ~DynamicDocsumWriter();
+ ~DynamicDocsumWriter() override;
ResultConfig *GetResultConfig() { return _resultConfig; }