1 files changed, 185 insertions, 0 deletions
diff --git a/bundle-plugin-test/integration-test/src/test/java/com/yahoo/container/plugin/BundleTest.java b/bundle-plugin-test/integration-test/src/test/java/com/yahoo/container/plugin/BundleTest.java
new file mode 100644
index 00000000000..a46abce1dff
--- /dev/null
+++ b/bundle-plugin-test/integration-test/src/test/java/com/yahoo/container/plugin/BundleTest.java
@@ -0,0 +1,185 @@
+// Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
+package com.yahoo.container.plugin;
+
+import com.yahoo.osgi.maven.ProjectBundleClassPaths;
+import com.yahoo.vespa.config.VespaVersion;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Collection;
+import java.util.Enumeration;
+import java.util.jar.Attributes;
+import java.util.jar.JarEntry;
+import java.util.jar.JarFile;
+import java.util.jar.Manifest;
+import java.util.regex.Pattern;
+import java.util.zip.ZipEntry;
+
+import static com.yahoo.osgi.maven.ProjectBundleClassPaths.CLASSPATH_MAPPINGS_FILENAME;
+import static java.nio.file.StandardCopyOption.REPLACE_EXISTING;
+import static org.hamcrest.CoreMatchers.allOf;
+import static org.hamcrest.CoreMatchers.anyOf;
+import static org.hamcrest.CoreMatchers.containsString;
+import static org.hamcrest.CoreMatchers.endsWith;
+import static org.hamcrest.CoreMatchers.hasItems;
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertThat;
+import static org.junit.Assert.assertTrue;
+
+/**
+ * Verifies the bundle jar file built and its manifest.
+ *
+ * @author Tony Vaagenes
+ */
+public class BundleTest {
+    static final String TEST_BUNDLE_PATH = System.getProperty("test.bundle.path", ".") + "/";
+
+    // If bundle-plugin-test is compiled in a mvn command that also built dependencies, e.g. jrt,
+    // the artifact is jrt.jar, otherwise the installed and versioned artifact
+    // is used: jrt-7-SNAPSHOT.jar or e.g. jrt-7.123.45.jar.
+    private static String snapshotOrVersionOrNone = "(-\\d+((-SNAPSHOT)|((\\.\\d+(\\.\\d+)?)?))?)?\\.jar";
+
+    private JarFile jarFile;
+    private Attributes mainAttributes;
+
+    @Before
+    public void setup() {
+        try {
+            File componentJar = findBundleJar("main");
+            jarFile = new JarFile(componentJar);
+            Manifest manifest = jarFile.getManifest();
+            mainAttributes = manifest.getMainAttributes();
+        } catch (IOException e) {
+            throw new RuntimeException(e);
+        }
+    }
+
+    static File findBundleJar(String bundleName) {
+        Path bundlePath = Paths.get(TEST_BUNDLE_PATH, bundleName + "-bundle.jar");
+        if (! Files.exists(bundlePath)) {
+            throw new RuntimeException("Failed finding component jar file: " + bundlePath);
+        }
+
+        return bundlePath.toFile();
+    }
+
+    @Test
+    public void require_that_bundle_version_is_added_to_manifest() {
+        String bundleVersion = mainAttributes.getValue("Bundle-Version");
+
+        // Because of snapshot builds, we can only verify the major version.
+        int majorBundleVersion = Integer.valueOf(bundleVersion.substring(0, bundleVersion.indexOf('.')));
+        assertThat(majorBundleVersion, is(VespaVersion.major));
+    }
+
+    @Test
+    public void require_that_bundle_symbolic_name_matches_pom_artifactId() {
+        assertThat(mainAttributes.getValue("Bundle-SymbolicName"), is("main"));
+    }
+
+    @Test
+    public void require_that_manifest_contains_inferred_imports() {
+        String importPackage = mainAttributes.getValue("Import-Package");
+
+        // From SimpleSearcher
+        assertThat(importPackage, containsString("com.yahoo.prelude.hitfield"));
+        assertThat(importPackage, containsString("org.json"));
+
+        // From SimpleSearcher2
+        assertThat(importPackage, containsString("com.yahoo.processing"));
+        assertThat(importPackage, containsString("com.yahoo.metrics.simple"));
+        assertThat(importPackage, containsString("com.google.inject"));
+    }
+
+    @Test
+    public void require_that_manifest_contains_manual_imports() {
+        String importPackage = mainAttributes.getValue("Import-Package");
+
+        assertThat(importPackage, containsString("manualImport.withoutVersion"));
+        assertThat(importPackage, containsString("manualImport.withVersion;version=\"12.3.4\""));
+
+        for (int i=1; i<=2; ++i)
+            assertThat(importPackage, containsString("multiple.packages.with.the.same.version" + i + ";version=\"[1,2)\""));
+    }
+
+    @Test
+    public void require_that_manifest_contains_exports() {
+        String exportPackage = mainAttributes.getValue("Export-Package");
+        assertThat(exportPackage, containsString("com.yahoo.test;version=1.2.3.RELEASE"));
+    }
+
+    @Test
+    // TODO: use another jar than jrt, which now pulls in a lot of dependencies that pollute the manifest of the
+    //       generated bundle. (It's compile scoped in pom.xml to be added to the bundle-cp.)
+    public void require_that_manifest_contains_bundle_class_path() {
+        String bundleClassPath = mainAttributes.getValue("Bundle-ClassPath");
+        assertThat(bundleClassPath, containsString(".,"));
+
+        Pattern jrtPattern = Pattern.compile("dependencies/jrt" + snapshotOrVersionOrNone);
+        assertTrue("Bundle class path did not contain jrt.", jrtPattern.matcher(bundleClassPath).find());
+    }
+
+    @Test
+    public void require_that_component_jar_file_contains_compile_artifacts() {
+        String depJrt = "dependencies/jrt";
+        Pattern jrtPattern = Pattern.compile(depJrt + snapshotOrVersionOrNone);
+        ZipEntry jrtEntry = null;
+
+        Enumeration<JarEntry> entries = jarFile.entries();
+        while (entries.hasMoreElements()) {
+            var e = entries.nextElement();
+            if (e.getName().startsWith(depJrt)) {
+                if (jrtPattern.matcher(e.getName()).matches()) {
+                    jrtEntry = e;
+                    break;
+                }
+            }
+        }
+        assertNotNull("Component jar file did not contain jrt dependency.", jrtEntry);
+    }
+
+
+    @Test
+    public void require_that_web_inf_url_is_propagated_to_the_manifest() {
+        String webInfUrl = mainAttributes.getValue("WebInfUrl");
+        assertThat(webInfUrl, containsString("/WEB-INF/web.xml"));
+    }
+
+    // TODO Vespa 8: Remove, the classpath mappings file is only needed for jersey resources to work in the application test framework.
+    //               When this test is removed, also remove the maven-resources-plugin from the 'main' test bundle's pom.
+    @Rule
+    public TemporaryFolder tempFolder = new TemporaryFolder();
+    @SuppressWarnings("unchecked")
+    @Test
+    public void bundle_class_path_mappings_are_generated() throws Exception {
+        ZipEntry classpathMappingsEntry = jarFile.getEntry(CLASSPATH_MAPPINGS_FILENAME);
+
+        assertNotNull(
+                "Could not find " + CLASSPATH_MAPPINGS_FILENAME + " in the test bundle",
+                classpathMappingsEntry);
+
+        Path mappingsFile = tempFolder.newFile(CLASSPATH_MAPPINGS_FILENAME).toPath();
+        Files.copy(jarFile.getInputStream(classpathMappingsEntry), mappingsFile, REPLACE_EXISTING);
+
+        ProjectBundleClassPaths bundleClassPaths = ProjectBundleClassPaths.load(mappingsFile);
+
+        assertThat(bundleClassPaths.mainBundle.bundleSymbolicName, is("main"));
+
+        Collection<String> mainBundleClassPaths = bundleClassPaths.mainBundle.classPathElements;
+
+        assertThat(mainBundleClassPaths,
+                hasItems(
+                        endsWith("target/classes"),
+                        anyOf(
+                                allOf(containsString("/jrt-"), containsString(".jar")),
+                                containsString("/jrt.jar"))));
+    }
+}