1 files changed, 74 insertions, 0 deletions
diff --git a/config-model/src/test/java/com/yahoo/searchdefinition/processing/ReservedMacroNamesTestCase.java b/config-model/src/test/java/com/yahoo/searchdefinition/processing/ReservedMacroNamesTestCase.java
new file mode 100644
index 00000000000..ba641dd4a3e
--- /dev/null
+++ b/config-model/src/test/java/com/yahoo/searchdefinition/processing/ReservedMacroNamesTestCase.java
@@ -0,0 +1,74 @@
+package com.yahoo.searchdefinition.processing;
+
+import com.yahoo.config.application.api.DeployLogger;
+import com.yahoo.searchdefinition.RankProfileRegistry;
+import com.yahoo.searchdefinition.Search;
+import com.yahoo.searchdefinition.SearchBuilder;
+import com.yahoo.searchdefinition.parser.ParseException;
+import org.junit.Test;
+
+import java.util.logging.Level;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+/**
+ * @author lesters
+ */
+public class ReservedMacroNamesTestCase {
+
+    @Test
+    public void requireThatMacrosWithReservedNamesIssueAWarning() throws ParseException {
+        RankProfileRegistry rankProfileRegistry = new RankProfileRegistry();
+        SearchBuilder builder = new SearchBuilder(rankProfileRegistry);
+        builder.importString(
+                "search test {\n" +
+                        "    document test { \n" +
+                        "        field a type string { \n" +
+                        "            indexing: index \n" +
+                        "        }\n" +
+                        "    }\n" +
+                        "    \n" +
+                        "    rank-profile test_rank_profile {\n" +
+                        "        macro not_a_reserved_name(x) {\n" +
+                        "            expression: x + x\n" +
+                        "        }\n" +
+                        "        macro sigmoid(x) {\n" +
+                        "            expression: x * x\n" +
+                        "        }\n" +
+                        "        first-phase {\n" +
+                        "            expression: sigmoid(2) + not_a_reserved_name(1)\n" +
+                        "        }\n" +
+                        "    }\n" +
+                        "    rank-profile test_rank_profile_2 inherits test_rank_profile {\n" +
+                        "        macro sin(x) {\n" +
+                        "            expression: x * x\n" +
+                        "        }\n" +
+                        "        first-phase {\n" +
+                        "            expression: sigmoid(2) + sin(1)\n" +
+                        "        }\n" +
+                        "    }\n" +
+                        "}\n");
+        builder.build();
+        Search search = builder.getSearch();
+        TestDeployLogger deployLogger = new TestDeployLogger();
+        ReservedMacroNames processor = new ReservedMacroNames(search, deployLogger, rankProfileRegistry, null);
+        processor.process();
+
+        assertTrue(deployLogger.log.contains("sigmoid") && deployLogger.log.contains("test_rank_profile"));
+        assertTrue(deployLogger.log.contains("sigmoid") && deployLogger.log.contains("test_rank_profile_2"));
+        assertTrue(deployLogger.log.contains("sin") && deployLogger.log.contains("test_rank_profile_2"));
+        assertFalse(deployLogger.log.contains("not_a_reserved_name") && deployLogger.log.contains("test_rank_profile"));
+        assertFalse(deployLogger.log.contains("not_a_reserved_name") && deployLogger.log.contains("test_rank_profile_2"));
+
+    }
+
+    public static class TestDeployLogger implements DeployLogger {
+        public String log = "";
+        @Override
+        public void log(Level level, String message) {
+            log += message;
+        }
+    }
+    
+}