summaryrefslogtreecommitdiffstats
path: root/container-core/src/main/java/com/yahoo/jdisc/http/server/jetty/HttpRequestDispatch.java
diff options
context:
space:
mode:
Diffstat (limited to 'container-core/src/main/java/com/yahoo/jdisc/http/server/jetty/HttpRequestDispatch.java')
-rw-r--r--container-core/src/main/java/com/yahoo/jdisc/http/server/jetty/HttpRequestDispatch.java4
1 files changed, 4 insertions, 0 deletions
diff --git a/container-core/src/main/java/com/yahoo/jdisc/http/server/jetty/HttpRequestDispatch.java b/container-core/src/main/java/com/yahoo/jdisc/http/server/jetty/HttpRequestDispatch.java
index 6b206116de8..0b7e27b9598 100644
--- a/container-core/src/main/java/com/yahoo/jdisc/http/server/jetty/HttpRequestDispatch.java
+++ b/container-core/src/main/java/com/yahoo/jdisc/http/server/jetty/HttpRequestDispatch.java
@@ -197,6 +197,7 @@ class HttpRequestDispatch {
requestContentChannel = requestHandler.handleRequest(jdiscRequest, servletResponseController.responseHandler);
}
+ //TODO If the below method throws requestContentChannel will not be close and there is a reference leak
ServletInputStream servletInputStream = jettyRequest.getInputStream();
ServletRequestReader servletRequestReader = new ServletRequestReader(servletInputStream,
@@ -204,6 +205,9 @@ class HttpRequestDispatch {
jDiscContext.janitor,
metricReporter);
+ //TODO If the below method throws servletRequestReader will not complete and
+ // requestContentChannel will not be closed and there is a reference leak
+ // Ditto for the servletInputStream
servletInputStream.setReadListener(servletRequestReader);
return servletRequestReader;
}