1 files changed, 145 insertions, 0 deletions
diff --git a/container-core/src/test/java/com/yahoo/container/jdisc/state/MetricsPacketsHandlerTest.java b/container-core/src/test/java/com/yahoo/container/jdisc/state/MetricsPacketsHandlerTest.java
new file mode 100644
index 00000000000..895cb885828
--- /dev/null
+++ b/container-core/src/test/java/com/yahoo/container/jdisc/state/MetricsPacketsHandlerTest.java
@@ -0,0 +1,145 @@
+// Copyright 2018 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
+package com.yahoo.container.jdisc.state;
+
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.yahoo.jdisc.Metric;
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+import static com.yahoo.container.jdisc.state.MetricsPacketsHandler.APPLICATION_KEY;
+import static com.yahoo.container.jdisc.state.MetricsPacketsHandler.DIMENSIONS_KEY;
+import static com.yahoo.container.jdisc.state.MetricsPacketsHandler.METRICS_KEY;
+import static com.yahoo.container.jdisc.state.MetricsPacketsHandler.STATUS_CODE_KEY;
+import static com.yahoo.container.jdisc.state.MetricsPacketsHandler.STATUS_MSG_KEY;
+import static com.yahoo.container.jdisc.state.MetricsPacketsHandler.TIMESTAMP_KEY;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+/**
+ * @author gjoranv
+ */
+public class MetricsPacketsHandlerTest extends StateHandlerTestBase {
+
+    @Test
+    public void only_status_packet_is_returned_prior_to_first_snapshot() throws Exception {
+        metric.add("not_included", 1, null);
+        String response = requestAsString("http://localhost/metrics-packets");
+
+        List<JsonNode> packets = toJsonPackets(response);
+        assertEquals(1, packets.size());
+
+        JsonNode statusPacket = packets.get(0);
+        assertEquals(statusPacket.toString(), APPLICATION_NAME, statusPacket.get(APPLICATION_KEY).asText());
+        assertEquals(statusPacket.toString(), 0, statusPacket.get(STATUS_CODE_KEY).asInt());
+        assertEquals(statusPacket.toString(), "up", statusPacket.get(STATUS_MSG_KEY).asText());
+    }
+
+    @Test
+    public void metrics_are_included_after_snapshot() throws Exception {
+        metric.add("counter", 1, null);
+        incrementCurrentTimeAndAssertSnapshot(SNAPSHOT_INTERVAL);
+        String response = requestAsString("http://localhost/metrics-packets");
+
+        List<JsonNode> packets = toJsonPackets(response);
+        assertEquals(2, packets.size());
+
+        JsonNode counterPacket = packets.get(1);
+        assertCountMetric(counterPacket, "counter.count", 1);
+    }
+
+    @Test
+    public void metadata_is_included_in_each_metrics_packet() throws Exception {
+        metric.add("counter", 1, null);
+        incrementCurrentTimeAndAssertSnapshot(SNAPSHOT_INTERVAL);
+        String response = requestAsString("http://localhost/metrics-packets");
+
+        List<JsonNode> packets = toJsonPackets(response);
+        JsonNode counterPacket = packets.get(1);
+
+        assertTrue(counterPacket.has(TIMESTAMP_KEY));
+        assertTrue(counterPacket.has(APPLICATION_KEY));
+        assertEquals(APPLICATION_NAME, counterPacket.get(APPLICATION_KEY).asText());
+    }
+
+    @Test
+    public void expected_aggregators_are_output_for_gauge_metrics() throws Exception{
+        Metric.Context context = metric.createContext(Collections.singletonMap("dim1", "value1"));
+        metric.set("gauge", 0.2, null);
+        incrementCurrentTimeAndAssertSnapshot(SNAPSHOT_INTERVAL);
+        String response = requestAsString("http://localhost/metrics-packets");
+
+        List<JsonNode> packets = toJsonPackets(response);
+        JsonNode gaugeMetric = packets.get(1).get(METRICS_KEY);
+        assertEquals(0.2, gaugeMetric.get("gauge.last").asDouble(), 0.1);
+        assertEquals(0.2, gaugeMetric.get("gauge.average").asDouble(), 0.1);
+        assertEquals(0.2, gaugeMetric.get("gauge.max").asDouble(), 0.1);
+    }
+
+    @Test
+    public void dimensions_from_context_are_included() throws Exception {
+        Metric.Context context = metric.createContext(Collections.singletonMap("dim1", "value1"));
+        metric.add("counter", 1, context);
+        incrementCurrentTimeAndAssertSnapshot(SNAPSHOT_INTERVAL);
+        String response = requestAsString("http://localhost/metrics-packets");
+
+        List<JsonNode> packets = toJsonPackets(response);
+        JsonNode counterPacket = packets.get(1);
+
+        assertTrue(counterPacket.has(DIMENSIONS_KEY));
+        JsonNode dimensions = counterPacket.get(DIMENSIONS_KEY);
+        assertEquals("value1", dimensions.get("dim1").asText());
+    }
+
+    @Test
+    public void metrics_with_identical_dimensions_are_contained_in_the_same_packet() throws Exception {
+        Metric.Context context = metric.createContext(Collections.singletonMap("dim1", "value1"));
+        metric.add("counter1", 1, context);
+        metric.add("counter2", 2, context);
+        incrementCurrentTimeAndAssertSnapshot(SNAPSHOT_INTERVAL);
+        String response = requestAsString("http://localhost/metrics-packets");
+
+        List<JsonNode> packets = toJsonPackets(response);
+        assertEquals(2, packets.size());
+        JsonNode countersPacket = packets.get(1);
+
+        assertEquals("value1", countersPacket.get(DIMENSIONS_KEY).get("dim1").asText());
+
+        assertCountMetric(countersPacket, "counter1.count", 1);
+        assertCountMetric(countersPacket, "counter2.count", 2);
+    }
+
+    @Test
+    public void metrics_with_different_dimensions_get_separate_packets() throws Exception {
+        Metric.Context context1 = metric.createContext(Collections.singletonMap("dim1", "value1"));
+        Metric.Context context2 = metric.createContext(Collections.singletonMap("dim2", "value2"));
+        metric.add("counter1", 1, context1);
+        metric.add("counter2", 1, context2);
+        incrementCurrentTimeAndAssertSnapshot(SNAPSHOT_INTERVAL);
+        String response = requestAsString("http://localhost/metrics-packets");
+
+        List<JsonNode> packets = toJsonPackets(response);
+        assertEquals(3, packets.size());
+    }
+
+    private List<JsonNode> toJsonPackets(String response) throws Exception {
+        List<JsonNode> jsonPackets = new ArrayList<>();
+        String[] packets = response.split("\\n\\n");
+        ObjectMapper mapper = new ObjectMapper();
+        for (String packet : packets) {
+            jsonPackets.add(mapper.readTree(mapper.getFactory().createParser(packet)));
+        }
+        return jsonPackets;
+    }
+
+    private void assertCountMetric(JsonNode metricsPacket, String metricName, long expected) {
+        assertTrue(metricsPacket.has(METRICS_KEY));
+        JsonNode counterMetrics = metricsPacket.get(METRICS_KEY);
+        assertTrue(counterMetrics.has(metricName));
+        assertEquals(expected, counterMetrics.get(metricName).asLong());
+    }
+
+}