1 files changed, 20 insertions, 32 deletions

diff --git a/container-search/src/main/java/com/yahoo/prelude/query/parser/SimpleParser.java b/container-search/src/main/java/com/yahoo/prelude/query/parser/SimpleParser.java
index 9ddfea6dffb..3d244312b2f 100644
--- a/container-search/src/main/java/com/yahoo/prelude/query/parser/SimpleParser.java
+++ b/container-search/src/main/java/com/yahoo/prelude/query/parser/SimpleParser.java
@@ -50,32 +50,28 @@ abstract class SimpleParser extends StructuredParser {
     private Item anyItemsBody(boolean topLevel) {
         Item topLevelItem = null;
         NotItem not = null;
-        Item item;
+        Item item = null;
 
         do {
-            item = null;
-
-            if (item == null) {
-                item = positiveItem();
-                if (item != null) {
-                    if (not == null) {
-                        not = new NotItem();
-                        not.addPositiveItem(item);
-                        topLevelItem = combineItems(topLevelItem, not);
-                    } else {
-                        not.addPositiveItem(item);
-                    }
+            item = positiveItem();
+            if (item != null) {
+                if (not == null) {
+                    not = new NotItem();
+                    not.addPositiveItem(item);
+                    topLevelItem = combineItems(topLevelItem, not);
+                } else {
+                    not.addPositiveItem(item);
                 }
             }
 
             if (item == null) {
                 item = negativeItem();
                 if (item != null) {
-                    if (not == null && item != null) {
+                    if (not == null) {
                         not = new NotItem();
                         not.addNegativeItem(item);
                         topLevelItem = combineItems(topLevelItem, not);
-                    } else if (item != null) {
+                    } else {
                         not.addNegativeItem(item);
                     }
                 }
@@ -97,9 +93,8 @@ abstract class SimpleParser extends StructuredParser {
                 if (item != null) {
                     if (topLevelItem == null) {
                         topLevelItem = item;
-                    } else if (needNewTopLevel(topLevelItem, item)) {
+                    } else if (needNewORTopLevel(topLevelItem, item)) {
                         CompositeItem newTop = new OrItem();
-
                         newTop.addItem(topLevelItem);
                         newTop.addItem(item);
                         topLevelItem = newTop;
@@ -131,6 +126,7 @@ abstract class SimpleParser extends StructuredParser {
 
             if (topLevelItem != null && topLevelItem != not) {
                 // => neutral rank items becomes implicit positives
+                System.out.println("Extracting positive item from " + topLevelItem);
                 not.addPositiveItem(getItemAsPositiveItem(topLevelItem, not));
                 return not;
             } else { // Only negatives - ignore them
@@ -144,21 +140,13 @@ abstract class SimpleParser extends StructuredParser {
         }
     }
 
-
-    /** Says whether we need a new top level item given the new item */
-    private boolean needNewTopLevel(Item topLevelItem, Item item) {
-        if (item == null) {
-            return false;
-        }
-        if (topLevelItem instanceof TermItem) {
-            return true;
-        }
-        if (topLevelItem instanceof PhraseItem) {
-            return true;
-        }
-        if (topLevelItem instanceof BlockItem) {
-            return true;
-        }
+    /** Says whether we need a new top level OR item given the new item */
+    private boolean needNewORTopLevel(Item topLevelItem, Item item) {
+        if (item == null) return false;
+        if (topLevelItem instanceof TermItem) return true;
+        if (topLevelItem instanceof PhraseItem) return true;
+        if (topLevelItem instanceof BlockItem) return true;
+        if ( topLevelItem instanceof AndItem) return true;
         return false;
     }