1 files changed, 97 insertions, 0 deletions
diff --git a/metrics-proxy/src/test/java/ai/vespa/metricsproxy/rpc/RpcHealthMetricsTest.java b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/rpc/RpcHealthMetricsTest.java
new file mode 100644
index 00000000000..20fb69e410e
--- /dev/null
+++ b/metrics-proxy/src/test/java/ai/vespa/metricsproxy/rpc/RpcHealthMetricsTest.java
@@ -0,0 +1,97 @@
+/*
+ * Copyright 2019 Oath Inc. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
+ */
+
+package ai.vespa.metricsproxy.rpc;
+
+import ai.vespa.metricsproxy.TestUtil;
+import ai.vespa.metricsproxy.metric.HealthMetric;
+import ai.vespa.metricsproxy.service.MockHttpServer;
+import ai.vespa.metricsproxy.service.VespaService;
+import com.yahoo.jrt.Request;
+import com.yahoo.jrt.Spec;
+import com.yahoo.jrt.StringValue;
+import com.yahoo.jrt.Supervisor;
+import com.yahoo.jrt.Target;
+import com.yahoo.jrt.Transport;
+import org.junit.Test;
+
+import java.util.List;
+
+import static ai.vespa.metricsproxy.rpc.IntegrationTester.SERVICE_1_CONFIG_ID;
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertThat;
+
+/**
+ * @author jobergum
+ * @author gjoranv
+ */
+public class RpcHealthMetricsTest {
+
+    private static final String HEALTH_OK_RESPONSE =
+            TestUtil.getContents("health-check.response.json");
+    private static final String HEALTH_FAILED_RESPONSE =
+            TestUtil.getContents("health-check-failed.response.json");
+    private static final String WANTED_RPC_RESPONSE =
+            TestUtil.getContents("rpc-json-output-check.json").trim();
+
+    // see factory/doc/port-ranges.txt
+    private static final int httpPort = 18635;
+    private static final int rpcPort = 18636;
+
+    @Test
+    public void expected_response_is_returned() {
+        try (IntegrationTester tester = new IntegrationTester(httpPort, rpcPort)) {
+
+            MockHttpServer mockHttpServer = tester.httpServer();
+            mockHttpServer.setResponse(HEALTH_OK_RESPONSE);
+            List<VespaService> services = tester.vespaServices().getInstancesById(SERVICE_1_CONFIG_ID);
+
+            assertThat(services.size(), is(1));
+            VespaService qrserver = services.get(0);
+            HealthMetric h = qrserver.getHealth();
+            assertNotNull("Health metric should never be null", h);
+            assertThat("Status failed, reason = " + h.getMessage(), h.isOk(), is(true));
+            assertThat(h.getMessage(), is("WORKING"));
+
+            mockHttpServer.setResponse(HEALTH_FAILED_RESPONSE);
+            h = qrserver.getHealth();
+            assertNotNull("Health metric should never be null", h);
+            assertThat("Status should be failed" + h.getMessage(), h.isOk(), is(false));
+            assertThat(h.getMessage(), is("SOMETHING FAILED"));
+
+            String jsonRPCMessage = getHealthMetrics(qrserver.getMonitoringName());
+            assertThat(jsonRPCMessage, is(WANTED_RPC_RESPONSE));
+        }
+    }
+
+    @Test
+    public void non_existent_service_name_returns_an_error_message() {
+        try (IntegrationTester tester = new IntegrationTester(httpPort, rpcPort)) {
+            String jsonRPCMessage = getHealthMetrics("non-existing service");
+            assertThat(jsonRPCMessage, is("105: No service with name 'non-existing service'"));
+        }
+    }
+
+    private String getHealthMetrics(String service) {
+        Supervisor supervisor = new Supervisor(new Transport());
+        Target target = supervisor.connect(new Spec("localhost", rpcPort));
+        Request req = new Request("getHealthMetricsForYamas");
+        req.parameters().add(new StringValue(service));
+        String returnValue;
+
+        target.invokeSync(req, 20.0);
+        if (req.checkReturnTypes("s")) {
+            returnValue = req.returnValues().get(0).asString();
+        } else {
+            System.out.println("RpcServer invocation failed " + req.errorCode() + ": " + req.errorMessage());
+            returnValue = req.errorCode() + ": " + req.errorMessage();
+        }
+        target.close();
+        supervisor.transport().shutdown().join();
+
+        return returnValue;
+    }
+
+}