diff options
Diffstat (limited to 'storage/src/tests/distributor/mergeoperationtest.cpp')
| -rw-r--r-- | storage/src/tests/distributor/mergeoperationtest.cpp | 82 |
1 files changed, 53 insertions, 29 deletions
diff --git a/storage/src/tests/distributor/mergeoperationtest.cpp b/storage/src/tests/distributor/mergeoperationtest.cpp index d174a6335b7..65ee5254193 100644 --- a/storage/src/tests/distributor/mergeoperationtest.cpp +++ b/storage/src/tests/distributor/mergeoperationtest.cpp @@ -37,6 +37,10 @@ struct MergeOperationTest : Test, DistributorStripeTestUtil { } std::shared_ptr<MergeOperation> setup_minimal_merge_op(); + std::shared_ptr<MergeOperation> setup_simple_merge_op(); + void assert_simple_merge_bucket_command(); + void assert_simple_delete_bucket_command(); + MergeBucketMetricSet& get_merge_metrics(); }; std::shared_ptr<MergeOperation> @@ -48,7 +52,9 @@ MergeOperationTest::setup_minimal_merge_op() return op; } -TEST_F(MergeOperationTest, simple) { +std::shared_ptr<MergeOperation> +MergeOperationTest::setup_simple_merge_op() +{ getClock().setAbsoluteTimeInSeconds(10); addNodesToBucketDB(document::BucketId(16, 1), @@ -58,44 +64,48 @@ TEST_F(MergeOperationTest, simple) { enable_cluster_state("distributor:1 storage:3"); - MergeOperation op(BucketAndNodes(makeDocumentBucket(document::BucketId(16, 1)), - toVector<uint16_t>(0, 1, 2))); - op.setIdealStateManager(&getIdealStateManager()); - op.start(_sender, framework::MilliSecTime(0)); + auto op = std::make_shared<MergeOperation>(BucketAndNodes(makeDocumentBucket(document::BucketId(16, 1)), toVector<uint16_t>(0, 1, 2))); + op->setIdealStateManager(&getIdealStateManager()); + op->start(_sender, framework::MilliSecTime(0)); + return op; +} +void +MergeOperationTest::assert_simple_merge_bucket_command() +{ ASSERT_EQ("MergeBucketCommand(BucketId(0x4000000000000001), to time 10000000, " "cluster state version: 0, nodes: [0, 2, 1 (source only)], chain: [], " "reasons to start: ) => 0", _sender.getLastCommand(true)); +} - sendReply(op); - +void +MergeOperationTest::assert_simple_delete_bucket_command() +{ ASSERT_EQ("DeleteBucketCommand(BucketId(0x4000000000000001)) " "Reasons to start: => 1", _sender.getLastCommand(true)); - } -TEST_F(MergeOperationTest, fail_if_source_only_copies_changed) { - getClock().setAbsoluteTimeInSeconds(10); - - addNodesToBucketDB(document::BucketId(16, 1), - "0=10/1/1/t," - "1=20/1/1," - "2=10/1/1/t"); - - enable_cluster_state("distributor:1 storage:3"); - - MergeOperation op(BucketAndNodes(makeDocumentBucket(document::BucketId(16, 1)), - toVector<uint16_t>(0, 1, 2))); - op.setIdealStateManager(&getIdealStateManager()); - op.start(_sender, framework::MilliSecTime(0)); +MergeBucketMetricSet& +MergeOperationTest::get_merge_metrics() +{ + return dynamic_cast<MergeBucketMetricSet&>(*getIdealStateManager().getMetrics().operations[IdealStateOperation::MERGE_BUCKET]); +} - std::string merge("MergeBucketCommand(BucketId(0x4000000000000001), to time 10000000, " - "cluster state version: 0, nodes: [0, 2, 1 (source only)], chain: [], " - "reasons to start: ) => 0"); +TEST_F(MergeOperationTest, simple) { + auto op = setup_simple_merge_op(); + ASSERT_NO_FATAL_FAILURE(assert_simple_merge_bucket_command()); + sendReply(*op); + ASSERT_NO_FATAL_FAILURE(assert_simple_delete_bucket_command()); + EXPECT_EQ(0, get_merge_metrics().ok.getValue()); + sendReply(*op); + EXPECT_EQ(1, get_merge_metrics().ok.getValue()); +} - ASSERT_EQ(merge, _sender.getLastCommand(true)); +TEST_F(MergeOperationTest, fail_if_source_only_copies_changed) { + auto op = setup_simple_merge_op(); + ASSERT_NO_FATAL_FAILURE(assert_simple_merge_bucket_command()); { auto& cmd = dynamic_cast<api::MergeBucketCommand&>(*_sender.command(0)); EXPECT_EQ(0, cmd.getSourceIndex()); @@ -106,10 +116,22 @@ TEST_F(MergeOperationTest, fail_if_source_only_copies_changed) { "0=10/1/1/t," "1=40/1/1," "2=10/1/1/t"); - sendReply(op); + sendReply(*op); // Should not be a remove here! - ASSERT_EQ(merge, _sender.getLastCommand(true)); - EXPECT_FALSE(op.ok()); + ASSERT_NO_FATAL_FAILURE(assert_simple_merge_bucket_command()); + EXPECT_FALSE(op->ok()); + EXPECT_EQ(1, get_merge_metrics().failed.getValue()); + EXPECT_EQ(1, get_merge_metrics().source_only_copy_changed.getValue()); +} + +TEST_F(MergeOperationTest, fail_if_delete_bucket_fails) { + auto op = setup_simple_merge_op(); + ASSERT_NO_FATAL_FAILURE(assert_simple_merge_bucket_command()); + sendReply(*op); + ASSERT_NO_FATAL_FAILURE(assert_simple_delete_bucket_command()); + sendReply(*op, -1, api::ReturnCode::ABORTED); + EXPECT_EQ(1, get_merge_metrics().failed.getValue()); + EXPECT_EQ(1, get_merge_metrics().source_only_copy_delete_failed.getValue()); } namespace { @@ -276,6 +298,8 @@ TEST_F(MergeOperationTest, do_not_remove_copies_with_pending_messages) { // Should not be a remove here! ASSERT_EQ(merge, _sender.getLastCommand(true)); EXPECT_FALSE(op.ok()); + EXPECT_EQ(1, get_merge_metrics().failed.getValue()); + EXPECT_EQ(1, get_merge_metrics().source_only_copy_delete_blocked.getValue()); } /* |