| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit allows protocol implementations to directly construct
and return a payload byte array that contains both the message
identifier and the serialized message itself _without_ having to
go through a `DocumentSerializer` indirection.
A new method has been added to the `RoutableFactory` whose default
implementation defers to the legacy `DocumentSerializer`-accepting
method. This means the v6 protocol has the same semantics and
performance characteristics as before.
The new Protobuf protocol implementation now allocates the result
byte array once with the correct size and writes both the message
ID header and the protobuf data into this.
This has the following performance benefits for the new protocol:
- Reduces the number of buffer _allocations_ from 3 to 1.
- Avoids 2 buffer _copies_ since we now directly allocate and write
into the resulting array.
- Encoding allocates the exact number of required bytes instead of
always allocating 8K at a minimum. This also avoids the need
for growing (by realloc and copy) the buffer during encoding.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds an entirely new implementation of the internal MessageBus
DocumentAPI protocol, which shall be functionally 1-to-1 compatible
with the existing legacy protocol.
New protobuf schemas have been added to the top-level documentapi
module, which are separated into different domains of responsibility:
* CRUD messages
* Visiting messages
* Data inspection messages
As well as a schema for shared, common message types.
Both C++ and Java protocol implementations separate serialization and
deserialization into a codec abstraction per message type, which
hides the boilerplate required for Protobuf buffer management. The
Java version is a tad more verbose due to generics type-erasure.
This protocol does _not_ currently support lazy (de-)serialization
in Java, as the existing mechanisms for doing so are inherently tied
to the legacy protocol version. Performance tests will decide if we
need to introduce such functionality to the new protocol version.
To avoid having the new protocol go live in production, this commit
changes the semantics of how MessageBus version reporting works (at
least for the near future); instead of reporting the current Vespa
_release_ version, it reports the highest supported _protocol_ version.
This lets us conditionally enable the new protocol by reporting a
MessageBus version greater than or equal to the protocol version _iff_
the protocol should be active.
The new protocol is disabled by default.
Other changes:
* Protocol tests have been moved up one package directory level to
be aligned with the actual package of the classes they test. This
allows for using package-protected constructors in the serialization
tests.
* `DocumentDeserializer` now exposes the underlying document type
repo/manager. This is done to detangle `Document`/`DocumentUpdate`
deserialization from the underlying wire buffer management.
* `RemoveLocationMessage` at long last contains a bucket space,
which was forgotten when we initially added this concept to the
other messages, and where the pain of adding it in later was
too big (not so anymore!).
Unit tests for both C++ and Java have been hoisted from the legacy
test suite, cleaned up and extended with additional cases. The C++
tests use the old unit test kit and should receive a good follow-up
washing and GTest-rewrite.
**Important**: due to how MessageBus protocol versioning works, the
final protocol version is _not_ yet decided, as setting it requires
syncing against our build systems. A follow-up commit will assign
the final version as well as include all required binary test files.
|
| |
|
| |
|
| |
|
|
|
|
| |
messages.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Also remove deprecated and unsupported header-only visitor parameter
|
| |
|
|
|
|
|
|
|
| |
Load types have not been properly supported for some time, so remove
the remaining API surfaces exposing them. Since load type config was
the last remaining use of <clients> in services.xml, remove that one
as well.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Load types have not been used in practice for years, and supporting
them in backend metrics etc. has long since been lacking. Prepare for
removing these on Vespa 8.
Most callsites are unchanged, aside from presumed safe changes such
as constructors used by dependency injection. Have added new overloads
without load types where these did not already exist to allow for
an orderly transition.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
This reverts commit c16712cc670a7a87fb078205030533b6a9b27ef1.
|
|
|
|
| |
This reverts commit 2e2e2edeb3ea99f2c04925070cf44601e2cd94fb.
|
| |
|
| |
|
| |
|
|
|
|
| |
This reverts commit d7359f7c72ff06889af594431baf4075e2b4da78.
|
| |
|
| |
|
|
|
|
| |
This reverts commit 75b2e4c11ea6463c335f1c77dab3fdb5493e5600.
|
| |
|
|
|
|
| |
this""
|
| |
|
| |
|
|
|
|
|
|
|
| |
vespa-engine/revert-15578-bratseth/apply-on-restart-take-10"
This reverts commit 4cf13bc7db215e77f7688e429f700880c115fe76, reversing
changes made to e21f385bd4f21326608f3a69325df4e96d4a65e5.
|
| |
|
|
|
|
|
|
|
| |
vespa-engine/revert-15575-bratseth/apply-on-restart-take-9"
This reverts commit b9f054f862e6fc7bdbf41b9404605e2a8ad6b249, reversing
changes made to 535b586bae36880259a792e2292f02b8495950fe.
|
| |
|
|
|
|
|
|
|
| |
vespa-engine/revert-15550-bratseth/apply-on-restart-take-8"
This reverts commit 916492da87189ff9a07e39b22c64f2e1e31ff53a, reversing
changes made to 3e5cf1de4c336c2e8d4f3a380dc242f402cb6dea.
|
| |
|