Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove dead code from FileStorManager unit test. | Tor Egge | 2023-08-31 | 1 | -27/+0 |
| | |||||
* | Do not generate metrics at all for distributor, there are none. | Henning Baldersheim | 2023-08-29 | 2 | -4/+5 |
| | |||||
* | GC stor-bucket-init.def | Henning Baldersheim | 2023-08-30 | 4 | -40/+0 |
| | |||||
* | GC traces of messageforwarder | Henning Baldersheim | 2023-08-30 | 3 | -7/+0 |
| | |||||
* | GC stor-integritychecker config | Henning Baldersheim | 2023-08-30 | 3 | -41/+0 |
| | |||||
* | GC unused config | Henning Baldersheim | 2023-08-30 | 3 | -40/+0 |
| | |||||
* | Unify code layout and use auto | Henning Baldersheim | 2023-08-29 | 1 | -139/+67 |
| | |||||
* | Remove void statement | Henning Baldersheim | 2023-08-29 | 1 | -1/+0 |
| | |||||
* | Let node info for cluster controller be explicit, and not a metric consumer. | Henning Baldersheim | 2023-08-29 | 13 | -75/+150 |
| | |||||
* | Modernize code | Henning Baldersheim | 2023-08-28 | 2 | -4/+4 |
| | |||||
* | Remove incorrect _doneInitialized check. | Henning Baldersheim | 2023-08-28 | 1 | -25/+20 |
| | |||||
* | Add noexecpt | Henning Baldersheim | 2023-08-28 | 2 | -5/+5 |
| | |||||
* | - Remove methods not used. | Henning Baldersheim | 2023-08-28 | 2 | -72/+68 |
| | | | | | - Remove parameters not used. - Make template parameter runtime parameter. | ||||
* | Simplify spec SeqToSet definition | Tor Brede Vekterli | 2023-08-24 | 1 | -3/+3 |
| | | | | | | A sequence of length n is defined as a function whose domain is equal to 1..n (note: 1-indexing), so just use the domain directly instead of manually constructing the range. | ||||
* | Merge pull request #28111 from vespa-engine/vekterli/minor-spec-simplifications | Tor Brede Vekterli | 2023-08-23 | 1 | -5/+5 |
|\ | | | | | Minor spec simplifications | ||||
| * | Minor spec simplifications | Tor Brede Vekterli | 2023-08-22 | 1 | -5/+5 |
| | | | | | | | | | | | | | | | | - Nat (the set of natural numbers) is already present in Integers, so no need to extend Naturals. - Instead of computing cardinality of constant sets to verify that that the provided set has at least one element, just compare against the empty set. | ||||
* | | Revert "Revert "Move condition variable notifications inside critical ↵ | Henning Baldersheim | 2023-08-22 | 1 | -6/+1 |
| | | | | | | | | sections" MERGEOK" | ||||
* | | Revert "Move condition variable notifications inside critical sections" | Henning Baldersheim | 2023-08-22 | 1 | -1/+6 |
| | | |||||
* | | Move condition variable notifications inside critical sections | Tor Brede Vekterli | 2023-08-22 | 1 | -6/+1 |
|/ | | | | | | | | | | | | Opportunistic notifications outside lock may not properly (from the perspective of the memory model) synchronize visibility across threads. Observed by TSan during node shutdown when destruction of a `condition_variable` in a `Stripe` (from the main thread) was not properly synchronized with a broadcast on the same cond var that was previously done by an async result handling task (from a task executor thread), even though destruction is sequenced after first acquiring all the relevant locks. | ||||
* | Merge pull request #28086 from ↵ | Tor Brede Vekterli | 2023-08-22 | 32 | -89/+854 |
|\ | | | | | | | | | vespa-engine/vekterli/distributor-operation-cancelling Implement edge-triggered distributor operation cancelling | ||||
| * | Improve naming and make branching more obvious | Tor Brede Vekterli | 2023-08-21 | 4 | -18/+21 |
| | | |||||
| * | Simplify `CancelScope` handling by moving out of optional | Tor Brede Vekterli | 2023-08-21 | 4 | -31/+14 |
| | | |||||
| * | Make partial cancellelation state part of the API | Tor Brede Vekterli | 2023-08-21 | 9 | -13/+16 |
| | | | | | | | | | | Also rename factory function to avoid explicit coupling to higher level semantics. | ||||
| * | Early return of empty node vector when fully canceled | Tor Brede Vekterli | 2023-08-21 | 1 | -0/+3 |
| | | |||||
| * | Implement edge-triggered distributor operation cancelling | Tor Brede Vekterli | 2023-08-18 | 32 | -89/+862 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Will be used for ensuring active operations do not mutate the bucket database upon completion with stale entries for buckets that may no longer be valid for that distributor to handle. Removes the need for today's "always-on" implicit checks for node state and bucket ownership upon every single DB update (which is potentially ABA-susceptible). Moving to edge-triggering is intentionally done to avoid ABA problems. Cancellation cases are: * Distributor ownership of bucket changed * Subset of target nodes has become unavailable Note: cancellation is not yet wired in; this code is cold. | ||||
* | | Merge pull request #28098 from vespa-engine/toregge/include-stream-header-filesv8.215.17 | Tor Egge | 2023-08-21 | 5 | -0/+5 |
|\ \ | | | | | | | Include sstream or ostream header file. | ||||
| * | | Include sstream or ostream header file. | Tor Egge | 2023-08-21 | 5 | -0/+5 |
| | | | |||||
* | | | Use typename when needed for clang 15. | Tor Egge | 2023-08-21 | 1 | -1/+1 |
|/ / | |||||
* / | Reduce massive inlining of complex code | Henning Baldersheim | 2023-08-18 | 1 | -44/+61 |
|/ | |||||
* | Use a single level hash_map with a compund key. | Henning Baldersheim | 2023-08-18 | 3 | -32/+25 |
| | |||||
* | Put map lookup in one place. | Henning Baldersheim | 2023-08-18 | 2 | -36/+33 |
| | |||||
* | Extract highest value for both documentCount, totalDocumentCount, metaCount ↵ | Henning Baldersheim | 2023-08-18 | 3 | -44/+48 |
| | | | | and usedFileSize in 1 iteration | ||||
* | Move vectors, not copy | Henning Baldersheim | 2023-08-18 | 4 | -26/+36 |
| | |||||
* | Add noexcept | Henning Baldersheim | 2023-08-18 | 2 | -3/+3 |
| | |||||
* | Unify code layout | Henning Baldersheim | 2023-08-18 | 1 | -12/+10 |
| | |||||
* | Merge pull request #28062 from vespa-engine/vekterli/post-review-changes | Henning Baldersheim | 2023-08-16 | 7 | -15/+15 |
|\ | | | | | Minor post-review changes | ||||
| * | Take existing map size into account when resizing up | Tor Brede Vekterli | 2023-08-16 | 1 | -1/+1 |
| | | |||||
| * | Use `std::span` with fixed extent instead of `ConstArrayRef` | Tor Brede Vekterli | 2023-08-16 | 2 | -3/+3 |
| | | |||||
| * | Rename destructive statistics read function to be more clear in its semantics | Tor Brede Vekterli | 2023-08-16 | 4 | -11/+11 |
| | | |||||
* | | Go back to vertical listing of long parameter lists. | Henning Baldersheim | 2023-08-16 | 1 | -4/+9 |
| | | |||||
* | | Rename methods to follow style in class | Henning Baldersheim | 2023-08-16 | 5 | -13/+11 |
| | | |||||
* | | GC last use of hasItem, and use lookup interface directly. | Henning Baldersheim | 2023-08-16 | 15 | -58/+50 |
| | | |||||
* | | Check size before checking content. | Henning Baldersheim | 2023-08-16 | 1 | -0/+1 |
| | | |||||
* | | Drop number of anonymous namespaces by grouping related methods together. | Henning Baldersheim | 2023-08-16 | 1 | -46/+34 |
| | | |||||
* | | - Avoid going via a temporary IdealNodesList. | Henning Baldersheim | 2023-08-14 | 17 | -236/+253 |
|/ | | | | | | | - Use ConstArrayRef to hide implementation. - Store all 3 node categories in a single vector. - Use a small_vector that can handle redundancy up to 5 without requiring extra memory allocation. - Build a hash_map if redundancy/groups > 32 for constant lookup time. | ||||
* | When splitting a large number of nodes into their leaf groups you end up ↵ | Henning Baldersheim | 2023-08-11 | 1 | -18/+21 |
| | | | | | | with many vectors with only a single node in them. Then it is more efficient to use a small_vector that keeps the 4 first entries within. Reduces # allocations and avoids indirection. | ||||
* | Merge pull request #28023 from vespa-engine/balder/minor-layout-cleanup | Henning Baldersheim | 2023-08-11 | 3 | -132/+45 |
|\ | | | | | Minor code health. | ||||
| * | Minor code health. | Henning Baldersheim | 2023-08-10 | 3 | -132/+45 |
| | | |||||
* | | Modern c++ for loop. | Henning Baldersheim | 2023-08-10 | 3 | -37/+33 |
| | | |||||
* | | Reduce use of default values in method calls | Henning Baldersheim | 2023-08-10 | 6 | -146/+63 |
| | |