From 38dca49ab42f7a465d986d6f1d05fcd3a43520dd Mon Sep 17 00:00:00 2001 From: gjoranv Date: Mon, 5 Nov 2018 11:02:57 +0100 Subject: Improve class comment. --- .../com/yahoo/container/jdisc/state/MetricsPacketsHandler.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java b/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java index 4859222d69a..719c99e147e 100644 --- a/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java +++ b/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java @@ -27,9 +27,11 @@ import java.util.Map; import static com.yahoo.container.jdisc.state.StateHandler.getSnapshotPreprocessor; /** - * This handler outputs metrics in a json-like format. Each individual metric is a json object (packet), - * but there is no outer array or object that wraps the metrics packets. This handler is not set up by - * default, but can be added to the applications's services configuration. + * This handler outputs metrics in a json-like format, consisting of a series of metrics packets. + * Each packet is a json object but there is no outer array or object that wraps the packets. + * To reduce the amount of output, a packet contains all metrics that share the same set of dimensions. + * + * This handler is not set up by default, but can be added to the applications's services configuration. * * This handler is protocol agnostic, so it cannot discriminate between e.g. http request * methods (get/head/post etc.). -- cgit v1.2.3 From e0033bdbb608f2c06766a4a8dde879fa09dc7902 Mon Sep 17 00:00:00 2001 From: gjoranv Date: Mon, 5 Nov 2018 11:15:04 +0100 Subject: Add a trailing newline to the output. --- .../java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java b/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java index 719c99e147e..1376b50dad9 100644 --- a/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java +++ b/container-core/src/main/java/com/yahoo/container/jdisc/state/MetricsPacketsHandler.java @@ -89,7 +89,7 @@ public class MetricsPacketsHandler extends AbstractRequestHandler { private byte[] buildMetricOutput() { try { - String output = getStatusPacket() + getAllMetricsPackets(); + String output = getStatusPacket() + getAllMetricsPackets() + "\n"; return output.getBytes(StandardCharsets.UTF_8); } catch (JSONException e) { throw new RuntimeException("Bad JSON construction.", e); -- cgit v1.2.3